You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/20 17:30:46 UTC

[GitHub] [iceberg] kbendick opened a new issue, #4828: [REST] Add MetadataUpdate.AssignUUID action types to OpenAPI spec

kbendick opened a new issue, #4828:
URL: https://github.com/apache/iceberg/issues/4828

   The MetadataUpdate actions AssignUUID is not listed in the OpenAPI spec.
   
   It's also not currently fully implemented, but we do have the code in place for JSON SerDe, as well as the class (only the `applyTo` logic has not been fleshed out yet).
   
   We will need to add it to the REST OpenAPI spec in the following enum, as well as add a class for it: https://github.com/apache/iceberg/blob/b8626eecc139f638b162f06a5f8f3c8bb210346a/open-api/rest-catalog-open-api.yaml#L1175-L1195
   
   The class itself is defined here: https://github.com/apache/iceberg/blob/b8626eecc139f638b162f06a5f8f3c8bb210346a/core/src/main/java/org/apache/iceberg/MetadataUpdate.java#L34-L49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick commented on issue #4828: [REST] Add MetadataUpdate.AssignUUID action types to OpenAPI spec

Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #4828:
URL: https://github.com/apache/iceberg/issues/4828#issuecomment-1138771607

   In an effort to keep the OpenAPI spec slimmed down, and because this class isn't implemented, we've decided to not add it for the moment.
   
   The use case for `AssignUUID` is almost somewhat theoretical. If people have tables that are _very_ old (e.g. from the 0.9.x days or from when the project was incubating), they might not have UUIDs (as the spec initially didn't call for them).
   
   Because we don't think this will be a common use case within OSS (nor within any of my own work), for simplicities sake we've decided to leave it out. That's also why the logic is not fully implemented.
   
   If somebody eventually _does_ need this (e.g. for registering tables or for updating table UUIDs for some reason other than during a normal commit workflow), then we can also add it to the spec. As @singhpk234 pointed out, the class I was actually looking for was `RemoveSnapshotRef`.
   
   Maybe Prashant should just take over my job for me 🙈.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] kbendick closed issue #4828: [REST] Add MetadataUpdate.AssignUUID action types to OpenAPI spec

Posted by GitBox <gi...@apache.org>.
kbendick closed issue #4828: [REST] Add MetadataUpdate.AssignUUID action types to OpenAPI spec
URL: https://github.com/apache/iceberg/issues/4828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org