You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/13 12:19:01 UTC

[GitHub] [arrow] kszucs opened a new pull request #10311: ARROW-12741: [CI] Configure GitHub Token for Nightly Builds

kszucs opened a new pull request #10311:
URL: https://github.com/apache/arrow/pull/10311


   This reverts commit dae3fcccca9bba114913b2b09564127bc0ee779e.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs closed pull request #10311: ARROW-12741: [CI] Configure Crossbow GitHub Token for Nightly Builds

Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10311:
URL: https://github.com/apache/arrow/pull/10311


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10311: ARROW-12741: [CI] Configure Crossbow GitHub Token for Nightly Builds

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10311:
URL: https://github.com/apache/arrow/pull/10311#issuecomment-840518628


   https://issues.apache.org/jira/browse/ARROW-12741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #10311: ARROW-12741: [CI] Configure Crossbow GitHub Token for Nightly Builds

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10311:
URL: https://github.com/apache/arrow/pull/10311#discussion_r632454367



##########
File path: dev/tasks/macros.jinja
##########
@@ -87,7 +87,7 @@ on:
       {% endfor %}
     {% endif %}
     env:
-      CROSSBOW_GITHUB_TOKEN: {{ '${{ secrets.GITHUB_TOKEN }}' }}
+      CROSSBOW_GITHUB_TOKEN: {{ '${{ secrets.CROSSBOW_GITHUB_TOKEN }}' }}

Review comment:
       LGTM




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on a change in pull request #10311: ARROW-12741: [CI] Configure Crossbow GitHub Token for Nightly Builds

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10311:
URL: https://github.com/apache/arrow/pull/10311#discussion_r632074335



##########
File path: dev/archery/archery/cli.py
##########
@@ -789,7 +789,9 @@ def integration(with_all=False, random_seed=12345, **args):
               default='-', required=True)
 @click.option('--arrow-token', envvar='ARROW_GITHUB_TOKEN',
               help='OAuth token for responding comment in the arrow repo')
-def trigger_bot(event_name, event_payload, arrow_token):
+@click.option('--crossbow-token', '-ct', envvar='CROSSBOW_GITHUB_TOKEN',
+              help='OAuth token for pushing to the crossow repository')
+def trigger_bot(event_name, event_payload, arrow_token, crossbow_token):

Review comment:
       We don't need to revert this change because `crossbow_token` isn't used in this function.

##########
File path: dev/tasks/macros.jinja
##########
@@ -87,7 +87,7 @@ on:
       {% endfor %}
     {% endif %}
     env:
-      CROSSBOW_GITHUB_TOKEN: {{ '${{ secrets.GITHUB_TOKEN }}' }}
+      CROSSBOW_GITHUB_TOKEN: {{ '${{ secrets.CROSSBOW_GITHUB_TOKEN }}' }}

Review comment:
       Can we try the following?
   
   ```suggestion
         CROSSBOW_GITHUB_TOKEN: {{ '${{ secrets.CROSSBOW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }}' }}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on pull request #10311: ARROW-12741: [CI] Configure Crossbow GitHub Token for Nightly Builds

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10311:
URL: https://github.com/apache/arrow/pull/10311#issuecomment-841177919


   Submitted build https://github.com/ursacomputing/crossbow/branches/all?query=build-300
   
   Using: `archery crossbow submit wheel-manylinux2010-cp36-amd64 --arrow-branch master`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org