You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/02/03 17:54:53 UTC
Review Request 72078: Factored out getting authorization server URI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72078/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10092
https://issues.apache.org/jira/browse/MESOS-10092
Repository: mesos
Description
-------
Factored out getting authorization server URI.
Diffs
-----
src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874
Diff: https://reviews.apache.org/r/72078/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72078: Factored out getting authorization service
URI.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72078/
-----------------------------------------------------------
(Updated Feb. 5, 2020, 1:58 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Changes
-------
fixed indentation
Bugs: MESOS-10092
https://issues.apache.org/jira/browse/MESOS-10092
Repository: mesos
Description
-------
Factored out getting authorization service URI.
Diffs (updated)
-----
src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874
Diff: https://reviews.apache.org/r/72078/diff/6/
Changes: https://reviews.apache.org/r/72078/diff/5-6/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72078: Factored out getting authorization service
URI.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72078/#review219500
-----------------------------------------------------------
Fix it, then Ship it!
src/uri/fetchers/docker.cpp
Lines 1169 (patched)
<https://reviews.apache.org/r/72078/#comment307698>
Too many spaces for the indent, we need two less.
- Qian Zhang
On Feb. 4, 2020, 8:06 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72078/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2020, 8:06 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10092
> https://issues.apache.org/jira/browse/MESOS-10092
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Factored out getting authorization service URI.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874
>
>
> Diff: https://reviews.apache.org/r/72078/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72078: Factored out getting authorization service
URI.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72078/
-----------------------------------------------------------
(Updated Feb. 4, 2020, 12:06 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Summary (updated)
-----------------
Factored out getting authorization service URI.
Bugs: MESOS-10092
https://issues.apache.org/jira/browse/MESOS-10092
Repository: mesos
Description (updated)
-------
Factored out getting authorization service URI.
Diffs (updated)
-----
src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874
Diff: https://reviews.apache.org/r/72078/diff/2/
Changes: https://reviews.apache.org/r/72078/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72078: Factored out getting authorization server
URI.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72078/#review219478
-----------------------------------------------------------
src/uri/fetchers/docker.cpp
Line 1071 (original), 1071 (patched)
<https://reviews.apache.org/r/72078/#comment307643>
This static method should be moved to the beginning of this file.
src/uri/fetchers/docker.cpp
Lines 1136-1137 (patched)
<https://reviews.apache.org/r/72078/#comment307644>
A newline between.
src/uri/fetchers/docker.cpp
Lines 1122-1147 (original), 1139-1165 (patched)
<https://reviews.apache.org/r/72078/#comment307646>
Need two spaces indent for this whole block.
- Qian Zhang
On Feb. 4, 2020, 1:54 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72078/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2020, 1:54 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10092
> https://issues.apache.org/jira/browse/MESOS-10092
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Factored out getting authorization server URI.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 75df80bfd59323e06bf563d15a98af244b5b1874
>
>
> Diff: https://reviews.apache.org/r/72078/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>