You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/29 09:06:41 UTC
[GitHub] [cordova-ios] erisu opened a new pull request #773: refactor: drop
uiwebview & default to wkwebview
erisu opened a new pull request #773: refactor: drop uiwebview & default to wkwebview
URL: https://github.com/apache/cordova-ios/pull/773
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...8ace315](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on a change in pull request #773:
refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r372443527
##########
File path: CordovaLib/Classes/Private/Plugins/CDVLocalStorage/CDVLocalStorage.m
##########
@@ -23,19 +23,12 @@ Licensed to the Apache Software Foundation (ASF) under one
@interface CDVLocalStorage ()
@property (nonatomic, readwrite, strong) NSMutableArray* backupInfo; // array of CDVBackupInfo objects
-#if !WK_WEB_VIEW_ONLY
-@property (nonatomic, readwrite, weak) id <UIWebViewDelegate> webviewDelegate;
-#endif
@end
@implementation CDVLocalStorage
Review comment:
I'm pretty sure that all the paths in this file for LocalStorage are UIWebView-specific. Worth a bit more investigation to be sure, but maybe this can be removed entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on a change in pull request #773:
refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376147466
##########
File path: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.h
##########
@@ -20,11 +20,7 @@
#import <Cordova/CDVPlugin.h>
#import <Cordova/CDVWhitelist.h>
-#if WK_WEB_VIEW_ONLY
#define CDVWebViewNavigationType int
Review comment:
`CDVWebViewNavigationType` is used here.
https://github.com/erisu/cordova-ios/blob/refactor/swap-webviews/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L105-L132
https://github.com/erisu/cordova-ios/blob/refactor/swap-webviews/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L134-L137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on issue #773: refactor: drop
uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...9f34c81](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] brodybits commented on issue #773: refactor: drop
uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
brodybits commented on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-587012458
If you need this update now, I think your best bet at this point would be to install from GitHub, for example:
- `cordova platform add github:apache/cordova-ios`
- `cordova platform add github:apache/cordova-ios#bce99f94`
There should also be a nightly tag on npm. In general, we do not actively support unstable versions from master or from nightly.
My understanding is that there are some breaking changes still in progress before we are ready to publish the new release.
In case you have any questions about the upcoming release I would highly recommend you followup with us on Slack or on the mailing list, follow links in the footer of cordova.io or cordova.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...8ace315](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...8c083f8](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...8c083f8](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] knight9999 commented on a change in pull request
#773: refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
knight9999 commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376224897
##########
File path: bin/templates/scripts/cordova/lib/prepare.js
##########
@@ -310,22 +308,6 @@ function handleBuildSettings (platformConfig, locations, infoPlist) {
events.emit('verbose', `Set SwiftVersion to "${swiftVersion}".`);
project.xcode.updateBuildProperty('SWIFT_VERSION', swiftVersion);
}
- if (wkWebViewOnly) {
- let wkwebviewValue = '1';
- if (wkWebViewOnly === 'true') {
- events.emit('verbose', 'Set WK_WEB_VIEW_ONLY.');
- } else {
- wkwebviewValue = '0';
- events.emit('verbose', 'Unset WK_WEB_VIEW_ONLY.');
- }
- project.xcode.updateBuildProperty('WK_WEB_VIEW_ONLY', wkwebviewValue);
Review comment:
This `WK_WEB_VIEW_ONLY` compile flag is used in users' project xcodeproj (Not in CordovaLib's xcodeproj).
The `WK_WEB_VIEW_ONLY` flag in users' xcodeproj is used in some plugins (like `cordova-plugin-inappbowser` where `WK_WEB_VIEW_ONLY` flag is used to check to remove `UIWebView` code). For the backward compatibility, should we keep this `WK_WEB_VIEW_ONLY` flag in users' project for the moment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on a change in pull request #773:
refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376864206
##########
File path: bin/templates/scripts/cordova/lib/prepare.js
##########
@@ -310,22 +308,6 @@ function handleBuildSettings (platformConfig, locations, infoPlist) {
events.emit('verbose', `Set SwiftVersion to "${swiftVersion}".`);
project.xcode.updateBuildProperty('SWIFT_VERSION', swiftVersion);
}
- if (wkWebViewOnly) {
- let wkwebviewValue = '1';
- if (wkWebViewOnly === 'true') {
- events.emit('verbose', 'Set WK_WEB_VIEW_ONLY.');
- } else {
- wkwebviewValue = '0';
- events.emit('verbose', 'Unset WK_WEB_VIEW_ONLY.');
- }
- project.xcode.updateBuildProperty('WK_WEB_VIEW_ONLY', wkwebviewValue);
Review comment:
Flag removed from JS. Flag has been hardcoded, to true, to ensure that the IAB plugin is forced to use WKWebView in this release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] knight9999 commented on a change in pull request
#773: refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
knight9999 commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376224897
##########
File path: bin/templates/scripts/cordova/lib/prepare.js
##########
@@ -310,22 +308,6 @@ function handleBuildSettings (platformConfig, locations, infoPlist) {
events.emit('verbose', `Set SwiftVersion to "${swiftVersion}".`);
project.xcode.updateBuildProperty('SWIFT_VERSION', swiftVersion);
}
- if (wkWebViewOnly) {
- let wkwebviewValue = '1';
- if (wkWebViewOnly === 'true') {
- events.emit('verbose', 'Set WK_WEB_VIEW_ONLY.');
- } else {
- wkwebviewValue = '0';
- events.emit('verbose', 'Unset WK_WEB_VIEW_ONLY.');
- }
- project.xcode.updateBuildProperty('WK_WEB_VIEW_ONLY', wkwebviewValue);
Review comment:
This `WK_WEB_VIEW_ONLY` compile flag (line 321) is used in users' project xcodeproj (Not in CordovaLib's xcodeproj).
The `WK_WEB_VIEW_ONLY` flag in users' xcodeproj is used in some plugins (like `cordova-plugin-inappbowser` where `WK_WEB_VIEW_ONLY` flag is used to check to remove `UIWebView` code). For the backward compatibility, I feel it is better to keep this `WK_WEB_VIEW_ONLY` flag in users' project for the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...94f46d3](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...8c083f8](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu merged pull request #773: refactor: drop
uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] knight9999 commented on a change in pull request
#773: refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
knight9999 commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376224897
##########
File path: bin/templates/scripts/cordova/lib/prepare.js
##########
@@ -310,22 +308,6 @@ function handleBuildSettings (platformConfig, locations, infoPlist) {
events.emit('verbose', `Set SwiftVersion to "${swiftVersion}".`);
project.xcode.updateBuildProperty('SWIFT_VERSION', swiftVersion);
}
- if (wkWebViewOnly) {
- let wkwebviewValue = '1';
- if (wkWebViewOnly === 'true') {
- events.emit('verbose', 'Set WK_WEB_VIEW_ONLY.');
- } else {
- wkwebviewValue = '0';
- events.emit('verbose', 'Unset WK_WEB_VIEW_ONLY.');
- }
- project.xcode.updateBuildProperty('WK_WEB_VIEW_ONLY', wkwebviewValue);
Review comment:
This `WK_WEB_VIEW_ONLY` compile flag is used in users' project xcodeproj (Not in CordovaLib's xcodeproj).
The `WK_WEB_VIEW_ONLY` flag in users' xcodeproj is used in some plugins (like `cordova-plugin-inappbowser` where `WK_WEB_VIEW_ONLY` flag is used to check to remove `UIWebView` code). For the backward compatibility, I feel it is better to keep this `WK_WEB_VIEW_ONLY` flag in users' project for the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on a change in pull request #773:
refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r372442496
##########
File path: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.h
##########
@@ -20,11 +20,7 @@
#import <Cordova/CDVPlugin.h>
#import <Cordova/CDVWhitelist.h>
-#if WK_WEB_VIEW_ONLY
#define CDVWebViewNavigationType int
Review comment:
Does this get used anywhere by WKWebView or should it be removed entirely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on a change in pull request #773:
refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r372442729
##########
File path: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
##########
@@ -95,13 +95,8 @@ - (CDVIntentAndNavigationFilterValue) filterUrl:(NSURL*)url
return [[self class] filterUrl:url intentsWhitelist:self.allowIntentsWhitelist navigationsWhitelist:self.allowNavigationsWhitelist];
}
-#if WK_WEB_VIEW_ONLY
#define CDVWebViewNavigationTypeLinkClicked 0
#define CDVWebViewNavigationTypeOther 5
Review comment:
Do these get used by our WKWebView implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...fd54ace](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...2c61b68](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] jpike88 commented on issue #773: refactor: drop
uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
jpike88 commented on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-586701290
@erisu now that this has been merged when can we look forward to next release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...9f34c81](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...fd54ace](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...fd54ace](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...8ace315](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #773: refactor:
drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#issuecomment-579665991
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=h1) Report
> Merging [#773](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 74.42% 74.26% -0.16%
==========================================
Files 11 11
Lines 1830 1815 -15
==========================================
- Hits 1362 1348 -14
+ Misses 468 467 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/773/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `83.74% <100%> (-0.32%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=footer). Last update [266d339...fd54ace](https://codecov.io/gh/apache/cordova-ios/pull/773?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] knight9999 commented on a change in pull request
#773: refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
knight9999 commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376224897
##########
File path: bin/templates/scripts/cordova/lib/prepare.js
##########
@@ -310,22 +308,6 @@ function handleBuildSettings (platformConfig, locations, infoPlist) {
events.emit('verbose', `Set SwiftVersion to "${swiftVersion}".`);
project.xcode.updateBuildProperty('SWIFT_VERSION', swiftVersion);
}
- if (wkWebViewOnly) {
- let wkwebviewValue = '1';
- if (wkWebViewOnly === 'true') {
- events.emit('verbose', 'Set WK_WEB_VIEW_ONLY.');
- } else {
- wkwebviewValue = '0';
- events.emit('verbose', 'Unset WK_WEB_VIEW_ONLY.');
- }
- project.xcode.updateBuildProperty('WK_WEB_VIEW_ONLY', wkwebviewValue);
Review comment:
This `WK_WEB_VIEW_ONLY` compile flag (at line 321) is used in users' project xcodeproj (Not in CordovaLib's xcodeproj).
The `WK_WEB_VIEW_ONLY` flag in users' xcodeproj is used in some plugins (like `cordova-plugin-inappbowser` where `WK_WEB_VIEW_ONLY` flag is used to check to remove `UIWebView` code). For the backward compatibility, I feel it is better to keep this `WK_WEB_VIEW_ONLY` flag in users' project for the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on a change in pull request #773:
refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r372440846
##########
File path: cordova-js-src/exec.js
##########
@@ -259,3 +163,12 @@ execProxy.nativeCallback = function () {
};
module.exports = execProxy;
+
+if (window.webkit && window.webkit.messageHandlers && window.webkit.messageHandlers.cordova && window.webkit.messageHandlers.cordova.postMessage) {
+ // unregister the old bridge
+ cordova.define.remove('cordova/exec');
Review comment:
We shouldn't need to do this hack if cordova/exec is already the right implementation for WKWebView
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on a change in pull request #773:
refactor: drop uiwebview & add wkwebview
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #773: refactor: drop uiwebview & add wkwebview
URL: https://github.com/apache/cordova-ios/pull/773#discussion_r376161077
##########
File path: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
##########
@@ -95,13 +95,8 @@ - (CDVIntentAndNavigationFilterValue) filterUrl:(NSURL*)url
return [[self class] filterUrl:url intentsWhitelist:self.allowIntentsWhitelist navigationsWhitelist:self.allowNavigationsWhitelist];
}
-#if WK_WEB_VIEW_ONLY
#define CDVWebViewNavigationTypeLinkClicked 0
#define CDVWebViewNavigationTypeOther 5
Review comment:
```
#define CDVWebViewNavigationTypeOther 5
```
Is a UIWebView specific value. For WKWebView, the WKNavigationType Other value is `-1` and not `5`. I have updated this value to represent the correct value for WKWebView.
The result of this value is used in the `shouldOverrideLoadWithRequest` method.
It is what determines if a link should load when coming from something other than an anchor tag. For example using `location.href` in JS. It is apart of the `allow-intent` stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org