You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/02 23:00:34 UTC

[GitHub] [beam] ibzib commented on a change in pull request #11269: [BEAM-9199] Require Dataflow --region in Python SDK.

ibzib commented on a change in pull request #11269: [BEAM-9199] Require Dataflow --region in Python SDK.
URL: https://github.com/apache/beam/pull/11269#discussion_r402644369
 
 

 ##########
 File path: sdks/python/apache_beam/options/pipeline_options_validator_test.py
 ##########
 @@ -38,9 +38,12 @@
 # Mock runners to use for validations.
 class MockRunners(object):
   class DataflowRunner(object):
-    pass
+    def get_default_gcp_region(self):
 
 Review comment:
   We could also just add `--region` to all the tests if you would prefer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services