You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2019/11/13 23:51:00 UTC

[jira] [Commented] (HIVE-22491) Use Collections emptyList

    [ https://issues.apache.org/jira/browse/HIVE-22491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973814#comment-16973814 ] 

Hive QA commented on HIVE-22491:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12985751/HIVE-22491.1.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19408/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19408/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19408/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-11-13 23:48:16.733
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-19408/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-11-13 23:48:16.736
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 065f305 HIVE-22279: Enable temporary table partitioning (Laszlo Pinter, reviewed by Adam Szita)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 065f305 HIVE-22279: Enable temporary table partitioning (Laszlo Pinter, reviewed by Adam Szita)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-11-13 23:48:21.501
+ rm -rf ../yetus_PreCommit-HIVE-Build-19408
+ mkdir ../yetus_PreCommit-HIVE-Build-19408
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-19408
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-19408/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
error: a/common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java: does not exist in index
error: a/hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java: does not exist in index
error: a/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/ZooKeeperCleanup.java: does not exist in index
error: a/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/ZooKeeperStorage.java: does not exist in index
error: a/kudu-handler/src/java/org/apache/hadoop/hive/kudu/KuduPredicateHandler.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlan.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePreFilteringRule.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java: does not exist in index
error: a/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java: does not exist in index
error: a/serde/src/java/org/apache/hadoop/hive/serde2/NullStructSerDe.java: does not exist in index
error: a/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDefaultTransformer.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index
error: a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java: does not exist in index
error: patch failed: common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java:19
Falling back to three-way merge...
Applied patch to 'common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java' with conflicts.
error: patch failed: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java:334
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java' with conflicts.
Going to apply patch with: git apply -p1
error: patch failed: common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java:19
Falling back to three-way merge...
Applied patch to 'common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java' with conflicts.
error: patch failed: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java:334
Falling back to three-way merge...
Applied patch to 'standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java' with conflicts.
U common/src/java/org/apache/hadoop/hive/common/HiveStatsUtils.java
U standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-19408
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12985751 - PreCommit-HIVE-Build

> Use Collections emptyList
> -------------------------
>
>                 Key: HIVE-22491
>                 URL: https://issues.apache.org/jira/browse/HIVE-22491
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>         Environment: https://docs.oracle.com/javase/8/docs/api/?java/util/Collections.html
> Use Collections#emptyList instead of instantiating empty ArrayLists
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-22491.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)