Re: Review Request 50378: FLUME-2960: Support Wildcards in directoryname in TaildirSource

[es...@protonmail.com]

> On July 29, 2016, 2:49 p.m., Attila Simon wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java, line 239
> > <https://reviews.apache.org/r/50378/diff/4/?file=1457767#file1457767line239>
> >
> >     Is this solution follow symlinks? If not then it would be a breaking change.
> 
> qiao wen wrote:
>     Sorry?I don't understand the meaning. Could you please explain it more clearly.

This version of Files.walkFileTree won't follow symlinks in its traversal. If you were to have a symlinked directory with logs inside then none of them would get picked up. To follow symlinks you need to use the other version of Files.walkFileTree that takes a set of options and pass in EnumSet.of(FileVisitOption.FOLLOW_LINKS).


- eskrm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50378/#review144092
-----------------------------------------------------------


On July 30, 2016, 5:33 a.m., qiao wen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50378/
> -----------------------------------------------------------
> 
> (Updated July 30, 2016, 5:33 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> In our log management project, we wan't to track many log files like this:
> /app/dir1/log.*
> /app/dir2/log.*
> ...
> /app/dirn/log.*
> But TaildirSource can't support wildcards in filegroup directory name. The following config is expected:
> a1.sources.r1.filegroups.fg = /app/*/log.*
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 3f08d8b 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java ad9f720 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java c341054 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java 097ee0b 
> 
> Diff: https://reviews.apache.org/r/50378/diff/
> 
> 
> Testing
> -------
> 
> All tests in TestTaildirSource passed.
> 
> 
> Thanks,
> 
> qiao wen
> 
>