Re: [PATCH] NNTPHandler.java does not dispatch next co

[ha...@kodemuse.com]

Confirmed your patch. It wasn't clear to me from the spec if the
current id needed to be returned or the updated id. Did the wrong
thing.

Confirmed patch by
$ telnet news4.euro.net 119
S: 201 news4.euro.net NNRP Service Ready - news@euro.net (no posting).
C: GROUP comp.lang.python
S: 211 4829 208102 212930 comp.lang.python
C: NEXT
S: 223 208103 <79...@posting.google.com> Article retrieved;
S: request text separately.
C: NEXT
S: 223 208104 <ok...@4ax.com> Article retrieved; reque
S: st text separately.
C: LAST
S: 223 208103 <79...@posting.google.com> Article retrieved;
S: request text separately.


I don't think this was the cause of offset by one issue. NEXT and LAST
are not used (at least at start communication time) by most nntp clients
and the NEXT code wasn't evaluated at all as Christian pointed out.

thanks for the good fixes. 
Harmeet

----- Original Message -----
From: "Christian Buchegger" <ch...@planet-interkom.de>
Sent: Thursday, August 29 2002, 7:35 AM

> Danny,
> 
> for a detailled explanation of the expected behavior have a look at the
> 9.1.1.3.2 NEXT Examples
> in the draft-ietf-nntpext-base-13.txt.
> 
> In the first example the previous behavior would have returned the article
> with the number 3000234
> whereas with the fix, the first next command after selecting a group returns
> the second article in
> this group. This is my understanding from what I read in the examples.
> 
> Additonally I doubt that this would exhibit a regresseion, as the involved
> code was never executed
> before due to the missing dispatch of the next command.
> 
> Christian
> 
> 
> ----- Original Message -----
> From: "Danny Angus" <da...@apache.org>
> To: "James Developers List" <ja...@jakarta.apache.org>
> Sent: Monday, August 26, 2002 9:48 PM
> Subject: RE: [PATCH] NNTPHandler.java does not dispatch next command
> 
> 
> > Christian,
> > I've commited this, but I'd appreciate you telling me what difference the
> > pre-increment/post-increment  article number change makes.
> > I know NNTP suffered from not displaying the first post to a group until a
> > second post had been made, and hope this isn't going to revive that bug.
> >
> > d.
> >   -----Original Message-----
> >   From: Christian Buchegger
> [mailto:christian.buchegger@planet-interkom.de]
> >   Sent: 26 August 2002 20:30
> >   To: james-dev@jakarta.apache.org
> >   Subject: [PATCH] NNTPHandler.java does not dispatch next command
> >
> >
> >   NNTPHandler.java does not dispatch the next command to the method
> doNEXT.
> >   Additionally the commands next and last behave like
> >
> >   send(header(CurrentArticleNumber++));
> >
> >   while they should behave like:
> >
> >   send(header(++CurrentArticleNumber));
> >
> >   The attached patch corrects both problems.
> >
> >   Christian
> >
> >
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>