You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bryancall (via GitHub)" <gi...@apache.org> on 2025/11/19 20:24:17 UTC
[PR] Fix format specifier for ip_source bitfield in header_rewrite [trafficserver]
bryancall opened a new pull request, #12677:
URL: https://github.com/apache/trafficserver/pull/12677
## Description
Fix format mismatch warning in header_rewrite plugin that causes build failure on Ubuntu 20.04 with -Werror.
## Changes
- Change format specifier from %d to %zu for private_data.ip_source in conditions.cc
- ip_source is a uint64_t bitfield, so it needs %zu instead of %d
## Testing
- Verified build succeeds on Ubuntu 20.04 with gcc and -Werror
- Reproduces and fixes the CI failure seen in https://ci.trafficserver.apache.org/job/master/job/os_build/46610/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix format specifier for ip_source bitfield in header_rewrite [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #12677:
URL: https://github.com/apache/trafficserver/pull/12677#issuecomment-3554547871
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix format specifier for ip_source bitfield in header_rewrite [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #12677:
URL: https://github.com/apache/trafficserver/pull/12677#issuecomment-3560271767
It looks like either the description is outdated or you forgot to git add the other change (tcpinfo).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix format specifier for ip_source bitfield in header_rewrite [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall merged PR #12677:
URL: https://github.com/apache/trafficserver/pull/12677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix format specifier for ip_source bitfield in header_rewrite [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #12677:
URL: https://github.com/apache/trafficserver/pull/12677#issuecomment-3560383245
@maskit I removed the tcpinfo in this commit, I am fixing only one issue at a time and will see what CI does next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org