You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/07 12:28:42 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

davids5 commented on a change in pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.
URL: https://github.com/apache/incubator-nuttx/pull/391#discussion_r389250241
 
 

 ##########
 File path: arch/arm/src/stm32/stm32f20xxf40xx_flash.c
 ##########
 @@ -77,12 +78,29 @@
 #define FLASH_OPTKEY2      0x4c5d6e7f
 #define FLASH_ERASEDVALUE  0xff
 
+#if CONFIG_STM32_PROGMEM_STARTBLOCK < 0 || \
 
 Review comment:
   This would help me this a non breaking change.
   ```suggestion
   #if !defined(CONFIG_STM32_PROGMEM_STARTBLOCK)
   #  define CONFIG_STM32_PROGMEM_STARTBLOCK 0
   #endif
   
   #if !defined(CONFIG_STM32_PROGMEM_LASTBLOCK)
   #  define CONFIG_STM32_PROGMEM_LASTBLOCK STM32_FLASH_NPAGES-1
   #endif
   
   #if CONFIG_STM32_PROGMEM_STARTBLOCK < 0 || \
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services