[GitHub] [beam] pawelpasterz edited a comment on pull request #13094: [BEAM-5570] Update javacc dependency

[GitBox <gi...@apache.org>]

pawelpasterz edited a comment on pull request #13094:
URL: https://github.com/apache/beam/pull/13094#issuecomment-709786961


   @iemejia @kanterov 
   I can see that after bumping up `javacc` in SQL the only one test failing is `BeamSqlDslAggregationTest#testUnsupportedDistinct`. It should fail due to incorrect distinct usage and actually, it is doing g so but `ParseException` message is a bit different. Here is the assertion:
   ```
   java.lang.AssertionError: 
   Expected: (an instance of org.apache.beam.sdk.extensions.sql.impl.ParseException and exception with cause exception with message a string containing "Encountered \"*\"")
        but: exception with cause exception with message a string containing "Encountered \"*\"" cause message was "Encountered "" at line 1, column 31.
   ```
   https://gist.github.com/pawelpasterz/59900c7051baf76f073d3aad4984a7ed
   As far as I was able to debug and figure it out on my own, I can say both cases reason for throwing `ParseException` is the same, just difference in message
   And that is true for even small version change `4.0` -> `4.1`.
   I am not even close to consider myself as beam's SQL module expert, tried to solve this issue on my own but failed to do so
   
   Is it possible to update `javacc` just in clickhouse module?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org