You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by winningsix <gi...@git.apache.org> on 2016/02/03 08:59:28 UTC
[GitHub] spark pull request: [SPARK-8321][SQL][WIP] Authorization Support(o...
GitHub user winningsix opened a pull request:
https://github.com/apache/spark/pull/11045
[SPARK-8321][SQL][WIP] Authorization Support(on all operations not only DDL) in Spark Sql
This PR enables Hive authorization V2(SQL based authorization). It adds authorization check after items are resolved. By converting logical plan node into ```HivePrivilegeObjects```, we are able to leveraging Hive SQL based authorization.
The PR is marked WIP since it has limited supports on SQL operation and doesn't rebase onto the latest upstream. And used for reviews and sharing what in mind.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/winningsix/spark SPARK_SQL_AUTHORIZATION
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11045
----
commit 9178b4468f44167f44d3a7cb18c34fcd010e3542
Author: Ferdinand Xu <ch...@intel.com>
Date: 2015-12-04T00:53:30Z
[SPARK-12145][SQL] Command 'Set Role [ADMIN|NONE|ALL]' doesn't work in SQL based authorization
commit 7351f835b564b0d8c6340678f938568d8822b752
Author: Ferdinand Xu <ch...@intel.com>
Date: 2016-01-19T02:50:50Z
Rebase code
commit 8055065ee636939169fd25c88b8db6fe3fc3a934
Author: Ferdinand Xu <ch...@intel.com>
Date: 2016-01-20T01:48:17Z
Fix import order issue
commit b99768d261ce7f7875603c8bc9c8d18c36f474fa
Author: Ferdinand Xu <ch...@intel.com>
Date: 2016-01-13T19:23:37Z
Add revoke supports
commit 4a7295199631fa558627bd7fbd68cd0e6f1edf22
Author: Ferdinand Xu <ch...@intel.com>
Date: 2016-02-01T03:37:59Z
Add SQL based authorization support initial part
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #11045: [SPARK-8321][SQL][WIP] Authorization Support(on a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #11045: [SPARK-8321][SQL][WIP] Authorization Support(on all oper...
Posted by zhaiyuyong <gi...@git.apache.org>.
Github user zhaiyuyong commented on the issue:
https://github.com/apache/spark/pull/11045
how do this in spark with version 2.1.0\u300b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #11045: [SPARK-8321][SQL][WIP] Authorization Support(on all oper...
Posted by yaooqinn <gi...@git.apache.org>.
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/11045
Hi @winningsix, I am interesting in your idea, and i am confusing about the field `userName` used in your code, 1)where is it be initialized? 2) is it used for privilege checking?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #11045: [SPARK-8321][SQL][WIP] Authorization Support(on all oper...
Posted by winningsix <gi...@git.apache.org>.
Github user winningsix commented on the issue:
https://github.com/apache/spark/pull/11045
@yaooqinn thank you for your interest. It's required by Hive side at SessionState. And it's not used for privilege check. Some companies have already used this pull request in their product environment with some modifications.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #11045: [SPARK-8321][SQL][WIP] Authorization Support(on all oper...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/11045
Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one. We can also continue the discussion on the JIRA ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-8321][SQL][WIP] Authorization Support(o...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11045#issuecomment-179077963
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #11045: [SPARK-8321][SQL][WIP] Authorization Support(on all oper...
Posted by winningsix <gi...@git.apache.org>.
Github user winningsix commented on the issue:
https://github.com/apache/spark/pull/11045
@yaooqinn yes, the validation is working on server side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #11045: [SPARK-8321][SQL][WIP] Authorization Support(on all oper...
Posted by yaooqinn <gi...@git.apache.org>.
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/11045
@winningsix Glad to hear from you. And we can only use this through Spark ThriftServer, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-8321][SQL][WIP] Authorization Support(o...
Posted by winningsix <gi...@git.apache.org>.
Github user winningsix commented on the pull request:
https://github.com/apache/spark/pull/11045#issuecomment-179572731
Hi @rxin, could you help review this PR? This PR is kind of POC code and serve as illustrating how to enable Hive authorization V2 in Spark SQL side. We can divide this task into several smaller sub tasks if we are in the right direction. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org