You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by 10110346 <gi...@git.apache.org> on 2017/06/10 09:13:39 UTC
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/18259
[SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is leaked in WorkerSuite
## What changes were proposed in this pull request?
Create rpcEnv and run later needs shutdown. as #18226
## How was this patch tested?
unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/10110346/spark wip-lx-0610
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18259
----
commit 77653f4308d11ea6fa49a709cd0f3f74bb112187
Author: liuxian <li...@zte.com.cn>
Date: 2017-06-10T09:04:44Z
Create rpcEnv and run later needs shutdown and awaitTermination
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77929/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77955/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77955/testReport)** for PR 18259 at commit [`67913fd`](https://github.com/apache/spark/commit/67913fdd33d88cc2ffedd8a4cd6886421aa8684d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77980/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77980/testReport)** for PR 18259 at commit [`4787b9b`](https://github.com/apache/spark/commit/4787b9ba12177ba9bf89ae8c5711264425e34514).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18259
@10110346 do you know of other related changes? we should make them all at once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77980/testReport)** for PR 18259 at commit [`4787b9b`](https://github.com/apache/spark/commit/4787b9ba12177ba9bf89ae8c5711264425e34514).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/18259
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77873/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77929/testReport)** for PR 18259 at commit [`d4ee0ce`](https://github.com/apache/spark/commit/d4ee0ceac3c1175fc6e3469a0c49619ce80aa1ef).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77873/testReport)** for PR 18259 at commit [`77653f4`](https://github.com/apache/spark/commit/77653f4308d11ea6fa49a709cd0f3f74bb112187).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121296399
--- Diff: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
+ assert(_worker === null, "Some Worker's RpcEnv is leaked in tests")
+ val securityMgr = new SecurityManager(conf)
+ val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, securityMgr)
+ _worker = new Worker(rpcEnv, 50000, 20, 1234 * 5, Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
+ "Worker", "/tmp", conf, securityMgr)
+ _worker
+ }
+ after {
--- End diff --
@srowen Because `BeforeAndAfter` is a `trait`,so we can simplify.
I referenced the 'MasterSuite.scala'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121343480
--- Diff: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
+ assert(_worker === null, "Some Worker's RpcEnv is leaked in tests")
+ val securityMgr = new SecurityManager(conf)
+ val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, securityMgr)
+ _worker = new Worker(rpcEnv, 50000, 20, 1234 * 5, Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
+ "Worker", "/tmp", conf, securityMgr)
+ _worker
+ }
+ after {
--- End diff --
Space before for readability
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121345316
--- Diff: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
+ assert(_worker === null, "Some Worker's RpcEnv is leaked in tests")
+ val securityMgr = new SecurityManager(conf)
+ val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, securityMgr)
+ _worker = new Worker(rpcEnv, 50000, 20, 1234 * 5, Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
+ "Worker", "/tmp", conf, securityMgr)
+ _worker
+ }
+ after {
--- End diff --
@srowen I agree with you, i will change this one,thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121275989
--- Diff: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
+ assert(_worker === null, "Some Worker's RpcEnv is leaked in tests")
+ val securityMgr = new SecurityManager(conf)
+ val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, securityMgr)
+ _worker = new Worker(rpcEnv, 50000, 20, 1234 * 5, Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
+ "Worker", "/tmp", conf, securityMgr)
+ _worker
+ }
+ after {
--- End diff --
Shouldn't this be `override def after(): Unit = {`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18259
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77873/testReport)** for PR 18259 at commit [`77653f4`](https://github.com/apache/spark/commit/77653f4308d11ea6fa49a709cd0f3f74bb112187).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77955/testReport)** for PR 18259 at commit [`67913fd`](https://github.com/apache/spark/commit/67913fdd33d88cc2ffedd8a4cd6886421aa8684d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/18259
@srowen Thanks. I have checked in the whole project,there are no more related changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77964/testReport)** for PR 18259 at commit [`4787b9b`](https://github.com/apache/spark/commit/4787b9ba12177ba9bf89ae8c5711264425e34514).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121343459
--- Diff: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
--- End diff --
Space before
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121343440
--- Diff: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
+ assert(_worker === null, "Some Worker's RpcEnv is leaked in tests")
+ val securityMgr = new SecurityManager(conf)
+ val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, securityMgr)
+ _worker = new Worker(rpcEnv, 50000, 20, 1234 * 5, Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
+ "Worker", "/tmp", conf, securityMgr)
+ _worker
+ }
+ after {
--- End diff --
That's bad practice, and why `override` exists. For example if you wrote `afer {` you'd maybe never notice that your cleanup code was silently not being triggered.
The code doesn't do this consistently, but more often does write the full declaration, which is probably a good idea. I'd recommend changing this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18259
**[Test build #77929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77929/testReport)** for PR 18259 at commit [`d4ee0ce`](https://github.com/apache/spark/commit/d4ee0ceac3c1175fc6e3469a0c49619ce80aa1ef).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18259#discussion_r121349066
--- Diff: core/src/test/scala/org/apache/spark/deploy/worker/WorkerSuite.scala ---
@@ -34,6 +34,23 @@ class WorkerSuite extends SparkFunSuite with Matchers {
}
def conf(opts: (String, String)*): SparkConf = new SparkConf(loadDefaults = false).setAll(opts)
+ private var _worker: Worker = _
+ private def makeWorker(conf: SparkConf): Worker = {
+ assert(_worker === null, "Some Worker's RpcEnv is leaked in tests")
+ val securityMgr = new SecurityManager(conf)
+ val rpcEnv = RpcEnv.create("test", "localhost", 12345, conf, securityMgr)
+ _worker = new Worker(rpcEnv, 50000, 20, 1234 * 5, Array.fill(1)(RpcAddress("1.2.3.4", 1234)),
+ "Worker", "/tmp", conf, securityMgr)
+ _worker
+ }
+ after {
--- End diff --
@srowen I have tried to change it, But `after()` must write like this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcE...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18259: [SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is l...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18259
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77964/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org