You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by "kevinw66 (via GitHub)" <gi...@apache.org> on 2023/02/28 07:08:19 UTC

[GitHub] [ambari-metrics] kevinw66 opened a new pull request, #108: AMBARI-25876: Bump version to 3.0.0-SNAPSHOT

kevinw66 opened a new pull request, #108:
URL: https://github.com/apache/ambari-metrics/pull/108

   <!---
      Licensed to the Apache Software Foundation (ASF) under one or more
      contributor license agreements.  See the NOTICE file distributed with
      this work for additional information regarding copyright ownership.
      The ASF licenses this file to You under the Apache License, Version 2.0
      (the "License"); you may not use this file except in compliance with
      the License.  You may obtain a copy of the License at
          http://www.apache.org/licenses/LICENSE-2.0
      Unless required by applicable law or agreed to in writing, software
      distributed under the License is distributed on an "AS IS" BASIS,
      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
      See the License for the specific language governing permissions and
      limitations under the License.
   --->
   
   ## What changes were proposed in this pull request?
   
   (Please fill in changes proposed in this fix)
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. Ex: unit tests, manual tests)
   (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] kevinw66 commented on pull request #108: AMBARI-25876: Bump version to 3.0.0-SNAPSHOT

Posted by "kevinw66 (via GitHub)" <gi...@apache.org>.
kevinw66 commented on PR #108:
URL: https://github.com/apache/ambari-metrics/pull/108#issuecomment-1449186350

   > I thought we wanted to go with 2.8.0? But 3.0.0 is fine too since we don't have any released version numbers closer to 3.0.0.
   
   @virajjasani Since we change the format of the version number, upgrade major version might be better I think.
   
   > Besides, Ambari 2.8.0 would be the first release with ambari-metrics getting released separately, correct?
   
   Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] sekikn merged pull request #108: AMBARI-25876: Bump version to 3.0.0-SNAPSHOT

Posted by "sekikn (via GitHub)" <gi...@apache.org>.
sekikn merged PR #108:
URL: https://github.com/apache/ambari-metrics/pull/108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] virajjasani commented on pull request #108: AMBARI-25876: Bump version to 3.0.0-SNAPSHOT

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #108:
URL: https://github.com/apache/ambari-metrics/pull/108#issuecomment-1449148443

   I thought we wanted to go with 2.8.0? But 3.0.0 is fine too since we don't have any released version numbers closer to 3.0.0. 
   
   Besides, Ambari 2.8.0 would be the first release with ambari-metrics getting released separately, correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] sekikn commented on pull request #108: AMBARI-25876: Bump version to 3.0.0-SNAPSHOT

Posted by "sekikn (via GitHub)" <gi...@apache.org>.
sekikn commented on PR #108:
URL: https://github.com/apache/ambari-metrics/pull/108#issuecomment-1448289933

   +1, ensured that all version numbers in the code were updated and `mvn clean install -Dbuild-rpm` was successful on CentOS 7. Thanks @kevinw66!
   
   ```
   $ rpm -qip ambari-metrics-assembly/target/rpm/ambari-metrics-collector/RPMS/x86_64/ambari-metrics-collector-3.0.0-SNAPSHOT.x86_64.rpm 
   Name        : ambari-metrics-collector
   Version     : 3.0.0
   Release     : SNAPSHOT
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org


[GitHub] [ambari-metrics] virajjasani commented on pull request #108: AMBARI-25876: Bump version to 3.0.0-SNAPSHOT

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #108:
URL: https://github.com/apache/ambari-metrics/pull/108#issuecomment-1449187319

   Sounds good, thanks @kevinw66 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org