You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/08/17 20:31:06 UTC
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11262
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
[gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
This patch switches the URL to fetch gradle-wrapper.jar from
github.com to raw.githubusercontent.com. That's to be able to build
the Java part of the project at older Linux distros (RH < 7.4).
The github.com servers dropped TLSv1/TLSv1.1 support some time ago:
see [1] for details.
[1] https://githubengineering.com/crypto-removal-notice/
Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/11262/1
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle@66
PS1, Line 66: if ! curl -s -S --retry 3 -L -o "$wrapperJarPath" "$wrapperJarUrl"; then
> It seems here the line is not that long (and this is the source file). So,
agreed.
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:46:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11262
to look at the new patch set (#2).
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
[gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
This patch switches the URL to fetch gradle-wrapper.jar from
github.com to raw.githubusercontent.com. That's to be able to build
the Java part of the project at older Linux distros (RH < 7.4).
The github.com servers dropped TLSv1/TLSv1.1 support some time ago:
see [1] for details.
[1] https://githubengineering.com/crypto-removal-notice/
Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/11262/2
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle@66
PS1, Line 66: if ! curl -s -S --retry 3 -L -o "$wrapperJarPath" "$wrapperJarUrl"; then
If you want to keep those line breaks they need to be added here.
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradlew@86
PS1, Line 86: "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
Did you introduce these line breaks manually? This file is generated based on the edit you made in wrapper.gradle by running `gradle wrapper`.
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:34:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:46:23 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradlew@86
PS1, Line 86: "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
> Did you introduce these line breaks manually? This file is generated based
Woops, being uneducated about gradle, I just edited this file manually. I'll fix this, thanks for pointing this out.
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:36:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
Patch Set 2: Verified+1
Unrelated flakes:
* dist_test internal failure
* MultiThreadedRpcTest.TestBlowOutServiceQueue
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Sat, 18 Aug 2018 00:17:03 +0000
Gerrit-HasComments: No
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
[gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
This patch switches the URL to fetch gradle-wrapper.jar from
github.com to raw.githubusercontent.com. That's to be able to build
the Java part of the project at older Linux distros (RH < 7.4).
The github.com servers dropped TLSv1/TLSv1.1 support some time ago:
see [1] for details.
[1] https://githubengineering.com/crypto-removal-notice/
Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Reviewed-on: http://gerrit.cloudera.org:8080/11262
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:
http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle@66
PS1, Line 66: if ! curl -s -S --retry 3 -L -o "$wrapperJarPath" "$wrapperJarUrl"; then
> If you want to keep those line breaks they need to be added here.
It seems here the line is not that long (and this is the source file). So, I think it's OK to have it as is -- I don't think we need to care about line length in the generated files.
--
To view, visit http://gerrit.cloudera.org:8080/11262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14
Gerrit-Change-Number: 11262
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 17 Aug 2018 20:44:31 +0000
Gerrit-HasComments: Yes