You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/08/11 07:36:30 UTC
[GitHub] [commons-vfs] Wuchte opened a new pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Wuchte opened a new pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110
Create SftpChannel when it is required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] Wuchte edited a comment on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
Wuchte edited a comment on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-672038820
Hi @garydgregory
Can you take a look on fix?
EOL is fixed
I don't see easy way how to cover this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] Wuchte commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
Wuchte commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-672268695
some comments about test:
I tried add this test into ProviderWriteTests, but build was failed with timeout(with local debug looks like this scenario doesn't work with "file///..." prefix).
Due this I added this test only for SftpProvider.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] Wuchte commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
Wuchte commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-671917607
@garydgregory
Can you take a look patch in [Jira](https://issues.apache.org/jira/browse/VFS-780)?
Something is wrong with github, locally I see correct changeset.
About tests - I'm new in this project, does all providers support parallel access?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-672054268
Hi @Wuchte
We need a unit test to show what this fixes. Otherwise, it's just change that happens to not break existing code but there is no proof that it fixes anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-671920772
> @garydgregory
> Can you take a look patch in [Jira](https://issues.apache.org/jira/browse/VFS-780)?
> Something is wrong with github, locally I see correct changeset.
Hi @Wuchte
There is nothing wrong with GitHub; you'll need to consider your line ending settings here: https://docs.github.com/en/github/using-git/configuring-git-to-handle-line-endings
>
> About tests - I'm new in this project, does all providers support parallel access?
There is no general rule on multi-threaded access, you'll have to look at the code for each provider and see if they even document their threading model.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] Wuchte commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
Wuchte commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-672038820
Hi @garydgregory
Can you take a look on fix? EOL is fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-671914820
@Wuchte
Thank you for your PR... BUT... I can't tell what's changed since the whole file is marked here as a diff. May you try to provide a PR that properly shows you diffs please? Also, there is no way to see if the PR fixes anything without a failing unit test. Please see tests we already have for this provider for examples.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-674869509
@Wuchte I will take a look tonight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] Wuchte commented on pull request #110: VFS-780 SftpFileSystem returns null channel and produce NPE - fix get…
Posted by GitBox <gi...@apache.org>.
Wuchte commented on pull request #110:
URL: https://github.com/apache/commons-vfs/pull/110#issuecomment-674848929
Hi @garydgregory, can you take a look on changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org