You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/29 06:19:57 UTC
[GitHub] [calcite] julianhyde opened a new pull request #2047: [CALCITE-3936] JDBC adapter, when generating SQL, changes target of ambiguous HAVING clause with a Project on Filter on Aggregate
julianhyde opened a new pull request #2047:
URL: https://github.com/apache/calcite/pull/2047
In order to fix https://issues.apache.org/jira/browse/CALCITE-3936, we needed significant refactoring of `SqlImplementor` and `RelToSqlConverter`.
There are various changes to the signatures of protected methods; I don't consider them public APIs: Renamed `SqlImplementor.visitChild` to `visitInput`, replaced `Sqlmplementor.Result.builder(RelNode, Clause...)` with two methods, `builder(RelNode)` and `builder(RelNode, Clause, Clause...)`, the latter of which is deprecated.
The changes have not yet been squashed, and incorrectly reference CALCITE-3896; should be CALCITE-3936.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde closed pull request #2047: [CALCITE-3936] JDBC adapter, when generating SQL, changes target of ambiguous HAVING clause with a Project on Filter on Aggregate
Posted by GitBox <gi...@apache.org>.
julianhyde closed pull request #2047:
URL: https://github.com/apache/calcite/pull/2047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] chunweilei commented on pull request #2047: [CALCITE-3936] JDBC adapter, when generating SQL, changes target of ambiguous HAVING clause with a Project on Filter on Aggregate
Posted by GitBox <gi...@apache.org>.
chunweilei commented on pull request #2047:
URL: https://github.com/apache/calcite/pull/2047#issuecomment-657941772
@julianhyde Could you please squash commits and merge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org