You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/01 07:20:52 UTC
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading
for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-385615006
I got chunk names to update (see exact webpack input / output below) and wanted to post some numbers from local dashboard testing which all look pretty good:
- average total payload **decreased by 5 MB**
- DOM content load time **decreased 3.4s**
- Page load time **decreased 1.1s**
- the average # requests **increased by 6**
| Total payload (MB) | |
-- | -- | -- | --
Dashboard | Before | After |
Births example | 12.4 | 6.9 | -5.5
World data example | 12.4 | 8.7 | -3.7
Misc charts example | 14.9 | 8.5 | -6.4
Misc charts example w Deck gl | 15.4 | 11.1 | -4.3
| DOM content loaded (seconds) | |
-- | -- | -- | --
Dashboard | Before | After | Delta
Births example | 7.69 | 2.93 | -4.76
World data example | 6.58 | 2.63 | -3.95
Misc charts example | 6.38 | 3.88 | -2.50
Misc charts example w Deck gl | 6.20 | 2.71 | -3.49
| Total time (seconds) | |
-- | -- | -- | --
Dashboard | Before | After | Delta
Births example | 9.25 | 6.87 | -2.38
World data example | 9.22 | 6.78 | -2.44
Misc charts example | 7.69 | 5.53 | -2.16
Misc charts example w Deck gl | 7.73 | 10.19 | +2.45
| Requests (count) | |
-- | -- | -- | --
Dashboard | Before | After | Delta
Births example | 32 | 36 | +4
World data example | 29 | 34 | +5
Misc charts example | 45 | 53 | +8
Misc charts example w Deck gl | 59 | 67 | +8
webpack output before
```
Hash: 09e816a63d54c8a794f4
Version: webpack 3.10.0
Time: 44176ms (44s)
Asset Size Chunks Chunk Names
welcome.f1949d0f24772fdd90be.entry.js 8.49 MB 5, 6 [emitted] [big] welcome
f4769f9bdb7466be65088239c12046d1.eot 20.1 kB [emitted]
fa2772327f55d8198301fdb8bcfc8158.woff 23.4 kB [emitted]
e18bbf611f2a2e43afc071aa2f4e1512.ttf 45.4 kB [emitted]
89889688147bd7575d6327160d64e760.svg 109 kB [emitted]
dashboard.7aae3890d2f0d6521e6e.entry.js 48.1 MB 0, 6 [emitted] [big] dashboard
explore.7876f80fe4be57a17e6c.entry.js 46.3 MB 1, 6 [emitted] [big] explore
sqllab.80cb1149088d4df08c50.entry.js 17.8 MB 2, 6 [emitted] [big] sqllab
profile.87ba695abcd8682ad921.entry.js 8.57 MB 3, 6 [emitted] [big] profile
addSlice.f27f6a8368fce90f27ca.entry.js 9.18 MB 4, 6 [emitted] [big] addSlice
448c34a56d699c29117adc64c43affeb.woff2 18 kB [emitted]
common.540032da3aeaf1cdc78e.entry.js 3.85 MB 6 [emitted] [big] common
theme.912f2edddcf1890cf5f2.entry.js 6.12 kB 7 [emitted] theme
theme.912f2edddcf1890cf5f2.css 321 kB 7 [emitted] [big] theme
explore.7876f80fe4be57a17e6c.css 85.5 kB 1, 6 [emitted] explore
dashboard.7aae3890d2f0d6521e6e.css 92.9 kB 0, 6 [emitted] dashboard
sqllab.80cb1149088d4df08c50.css 7.01 kB 2, 6 [emitted] sqllab
welcome.f1949d0f24772fdd90be.css 846 bytes 5, 6 [emitted] welcome
profile.87ba695abcd8682ad921.css 1.04 kB 3, 6 [emitted] profile
manifest.json 1.17 kB [emitted]
[31] ./src/locales.jsx 5.63 kB {0} {1} {2} {3} {4} {5} {6} [built]
[544] ./src/common.js 1.52 kB {0} {1} {2} {3} {4} {5} {6} [built]
[2877] ./src/theme.js 152 bytes {7} [built]
[2879] ./stylesheets/react-select/select.less 41 bytes {7} [built]
[2881] multi babel-polyfill ./src/addSlice/index.jsx 40 bytes {4} [built]
[2882] ./src/addSlice/index.jsx 793 bytes {4} [built]
[2884] multi babel-polyfill ./src/explore/index.jsx 40 bytes {1} [built]
[2885] ./src/explore/index.jsx 3.53 kB {1} [built]
[2910] multi babel-polyfill ./src/dashboard/index.jsx 40 bytes {0} [built]
[2911] ./src/dashboard/index.jsx 1.47 kB {0} [built]
[2976] multi babel-polyfill ./src/SqlLab/index.jsx 40 bytes {2} [built]
[2977] ./src/SqlLab/index.jsx 1.55 kB {2} [built]
[3062] multi babel-polyfill ./src/welcome/index.jsx 40 bytes {5} [built]
[3066] multi babel-polyfill ./src/profile/index.jsx 40 bytes {3} [built]
[3067] ./src/profile/index.jsx 775 bytes {3} [built]
+ 3119 hidden modules
```
webpack output after
```
Hash: 460ae189f7f00025375d
Version: webpack 3.11.0
Time: 45052ms
Asset Size Chunks Chunk Names
parallel_coordinates.e19f30010f7bbf13546b.chunk.js 204 kB 22 [emitted] parallel_coordinates
f4769f9bdb7466be65088239c12046d1.eot 20.1 kB [emitted]
fa2772327f55d8198301fdb8bcfc8158.woff 23.4 kB [emitted]
e18bbf611f2a2e43afc071aa2f4e1512.ttf 45.4 kB [emitted]
89889688147bd7575d6327160d64e760.svg 109 kB [emitted]
big_number.79adb118812eccd063fb.chunk.js 53.5 kB 0 [emitted] big_number
markup.948cb22fcab6b19f2e4a.chunk.js 19.5 kB 1 [emitted] markup
filter_box.91002d1d9472edde49bf.chunk.js 12 MB 2 [emitted] [big] filter_box
nvd3_vis.281a1af3a506a8e3884a.chunk.js 6.8 MB 3 [emitted] [big] nvd3_vis
deckgl/multi.d6e764166d7b4103af7b.chunk.js 9.32 MB 4, 5, 6, 7, 8, 9, 10, 11, 12 [emitted] [big] deckgl/multi
deckgl/layers/scatter.b568ad5250e9d22975d9.chunk.js 9.24 MB 5 [emitted] [big] deckgl/layers/scatter
deckgl/layers/screengrid.1ee238f0aebaf8d8900b.chunk.js 9.21 MB 6 [emitted] [big] deckgl/layers/screengrid
deckgl/layers/polygon.97570d1ea352ddf510c1.chunk.js 8.82 MB 7 [emitted] [big] deckgl/layers/polygon
deckgl/layers/path.f323723cf70e8bf1a147.chunk.js 8.82 MB 8 [emitted] [big] deckgl/layers/path
deckgl/layers/hex.7cb60849a307eb9519ac.chunk.js 8.82 MB 9 [emitted] [big] deckgl/layers/hex
deckgl/layers/grid.bcf5bdb27ebbb42bc62a.chunk.js 8.82 MB 10 [emitted] [big] deckgl/layers/grid
deckgl/layers/geojson.cbe273cf0fb9776d61a8.chunk.js 8.82 MB 11 [emitted] [big] deckgl/layers/geojson
deckgl/layers/arc.39fe4230cf2b9752527d.chunk.js 8.82 MB 12 [emitted] [big] deckgl/layers/arc
time_table.95406246d98f54294384.chunk.js 1.52 MB 13 [emitted] [big] time_table
mapbox.67012446cc08ff6e6d3b.chunk.js 4.44 MB 14 [emitted] [big] mapbox
sankey.c1f5d4b1cd7fee7c1df5.chunk.js 268 kB 15 [emitted] [big] sankey
partition.b8e65a38f2ba807b683c.chunk.js 164 kB 16 [emitted] partition
paired_ttest.a8f0d23de7bf7d03f698.chunk.js 304 kB 17 [emitted] [big] paired_ttest
heatmap.d40eccee55ff046c5cbe.chunk.js 121 kB 18 [emitted] heatmap
cal_heatmap.6139e8dce5f6dcba25bb.chunk.js 369 kB 19 [emitted] [big] cal_heatmap
table.a2fd3be152bf2fca343d.chunk.js 2.11 MB 20 [emitted] [big] table
pivot_table.0d04def897b408ec3b1a.chunk.js 2.1 MB 21 [emitted] [big] pivot_table
448c34a56d699c29117adc64c43affeb.woff2 18 kB [emitted]
world_map.4bd7602539b8b4592dea.chunk.js 945 kB 23 [emitted] [big] world_map
word_cloud.b0132e63e142e2fd7f59.chunk.js 45 kB 24 [emitted] word_cloud
rose.a6ba8766b408b3e4f73d.chunk.js 1.71 MB 25 [emitted] [big] rose
histogram.1c13537ec243db524ad2.chunk.js 1.68 MB 26 [emitted] [big] histogram
treemap.794f7dd7d9794550ad1d.chunk.js 35.6 kB 27 [emitted] treemap
sunburst.6ffd5e2a361c18ed0d8e.chunk.js 39 kB 28 [emitted] sunburst
horizon.8abe55276c7820163e5a.chunk.js 23.6 kB 29 [emitted] horizon
directed_force.49dc8886c3f71bab1449.chunk.js 18 kB 30 [emitted] directed_force
country_map.2778be0dacd7c4394588.chunk.js 22.1 kB 31 [emitted] country_map
chord.176754155a97063f7613.chunk.js 14.3 kB 32 [emitted] chord
EventFlow.8c353f56f7543defba73.chunk.js 2.57 MB 33 [emitted] [big] EventFlow
iframe.b8be5f33d0c7897f3572.chunk.js 1.8 kB 34 [emitted] iframe
explore.4ef76280c9d4dd518109.entry.js 25.6 MB 35, 41 [emitted] [big] explore
sqllab.93043b1fe98d1f6f2b17.entry.js 19.8 MB 36, 41 [emitted] [big] sqllab
dashboard.2e52929a378e5a3bb690.entry.js 15.4 MB 37, 41 [emitted] [big] dashboard
profile.a489b8f49f5417a5d354.entry.js 8.71 MB 38, 41 [emitted] [big] profile
addSlice.f9974bb068e902b9230c.entry.js 9.32 MB 39, 41 [emitted] [big] addSlice
welcome.bd3f186ea503ea87abe2.entry.js 8.64 MB 40, 41 [emitted] [big] welcome
common.cfc61ebddf4e3f04d3e4.entry.js 3.99 MB 41 [emitted] [big] common
theme.d104d43a3618a91391ee.entry.js 6.15 kB 42 [emitted] theme
theme.d104d43a3618a91391ee.css 321 kB 42 [emitted] [big] theme
explore.4ef76280c9d4dd518109.css 7.43 kB 35, 41 [emitted] explore
dashboard.2e52929a378e5a3bb690.css 12.6 kB 37, 41 [emitted] dashboard
sqllab.93043b1fe98d1f6f2b17.css 7.01 kB 36, 41 [emitted] sqllab
welcome.bd3f186ea503ea87abe2.css 846 bytes 40, 41 [emitted] welcome
profile.a489b8f49f5417a5d354.css 1.04 kB 38, 41 [emitted] profile
manifest.json 3.47 kB [emitted]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services