You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/06 14:00:08 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
HyukjinKwon opened a new pull request, #38133:
URL: https://github.com/apache/spark/pull/38133
### What changes were proposed in this pull request?
This PR proposes to read the corresponding versions from POM in SBT build instead of hardcoding the dependency versions.
In addition, this PR removes Scala system libraries in the dependency.
### Why are the changes needed?
To avoid version duplication.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI in this PR should test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270525769
(the build passed - there seems a problem with linking the build to this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270105806
cc @grundprinzip @amaliujia @LuciferYang FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270666046
Not only PR linking, the master branch seems to be broken due to `ghcr.io/apache/apache-spark-ci-image`.
```
/usr/bin/docker --config /home/runner/work/_temp/.docker_ac20db86-d07f-459d-9681-cfa6ca3f8a2e pull ghcr.io/apache/apache-spark-ci-image:master-3197794220
Error response from daemon: manifest unknown
Error: Docker pull failed with exit code 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270868140
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1271013049
+1, late LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270558253
Seeming the same issue on my PR: so probably an infra issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270350314
Could you re-trigger GitHub Action, @HyukjinKwon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270558538
`Error: Unhandled error: HttpError: Resource not accessible by integration`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
URL: https://github.com/apache/spark/pull/38133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270106792
Build: https://github.com/HyukjinKwon/spark/actions/runs/3197768433/jobs/5221428135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38133: [SPARK-40680][CONNECT][BUILD] Avoid hardcoded versions in SBT build
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38133:
URL: https://github.com/apache/spark/pull/38133#issuecomment-1270543294
thanks the change itself LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org