You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/30 16:41:27 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #1858: Tidy up pom.xml files
ppalaga opened a new pull request #1858:
URL: https://github.com/apache/camel-quarkus/pull/1858
Some sorting and moving properties around
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1858: Tidy up pom.xml files
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1858:
URL: https://github.com/apache/camel-quarkus/pull/1858#discussion_r497727417
##########
File path: pom.xml
##########
@@ -277,6 +286,12 @@
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>3.1.0</version>
Review comment:
Good catch, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1858: Tidy up pom.xml files
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1858:
URL: https://github.com/apache/camel-quarkus/pull/1858#discussion_r497671446
##########
File path: pom.xml
##########
@@ -277,6 +286,12 @@
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>3.1.0</version>
Review comment:
Shouldn't that reference the version property?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1858: Tidy up pom.xml files
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1858:
URL: https://github.com/apache/camel-quarkus/pull/1858
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org