You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/27 00:39:20 UTC
[jira] [Commented] (DRILL-4880) Support JDBC driver registration
using ServiceLoader
[ https://issues.apache.org/jira/browse/DRILL-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524631#comment-15524631 ]
ASF GitHub Bot commented on DRILL-4880:
---------------------------------------
GitHub user laurentgo opened a pull request:
https://github.com/apache/drill/pull/596
DRILL-4880: Support JDBC driver registration using ServiceLoader
Support loading Drill driver using ServiceLoader. From the user perspective,
it means being able to use the driver without registering it first, like by using
Class.forName("org.apache.drill.jdbc.Driver") for example.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laurentgo/drill laurent/DRILL-4880
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #596
----
commit b3112b084d29eb9d4d09a1497457ca725335da84
Author: Laurent Goujon <la...@dremio.com>
Date: 2016-09-27T00:14:59Z
DRILL-4880: Support JDBC driver registration using ServiceLoader
Support loading Drill driver using ServiceLoader. From the user perspective,
it means being able to use the driver without registering it first, like by using
Class.forName("org.apache.drill.jdbc.Driver") for exxample.
----
> Support JDBC driver registration using ServiceLoader
> -----------------------------------------------------
>
> Key: DRILL-4880
> URL: https://issues.apache.org/jira/browse/DRILL-4880
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.8.0
> Environment: Windows Server 2012
> Reporter: Sudip Mukherjee
> Fix For: 1.9.0
>
>
> Currently drill-jdbc-all*.jar doesn't contain a META_INF/services/java.sql.Driver file which is apparently used to discover a service by Java ServiceLoader API.
> Can drill jdbc driver have this file like all the other jdbc drivers so that the driver can be loaded using ServiceLoader instead of a direct Class.forName?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)