You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Erik Bergenholtz <eb...@hortonworks.com> on 2015/06/19 22:17:47 UTC
Review Request 35666: Add Better HDFS Error Handling
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35666/
-----------------------------------------------------------
Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-12028
https://issues.apache.org/jira/browse/AMBARI-12028
Repository: ambari
Description
-------
Primary function of this patch is to add better HDFS error handling and retry in the case of a particular HDFS bug.
Diffs
-----
contrib/views/hive/pom.xml 6cd7c09
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js b3cd127
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js 5ab46f6
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js d6ae8c4
contrib/views/utils/pom.xml 76d04c7
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java 80603b5
Diff: https://reviews.apache.org/r/35666/diff/
Testing
-------
Ran Unit Tests for Hive and Utils + live deployment of view on cluster
Hive:
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.502 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.123 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.1 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.274 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.509 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.196 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.6 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.236 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.358 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.624 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.126 sec
Results :
Tests run: 48, Failures: 0, Errors: 0, Skipped: 0
Utils:
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.utils.ambari.RemoteClusterTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec
Running org.apache.ambari.view.utils.ambari.URLStreamProviderBasicAuthTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec
Running org.apache.ambari.view.utils.ViewUserLocalTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
Running org.apache.ambari.view.utils.hdfs.ConfigurationBuilderTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.15 sec
Results :
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Erik Bergenholtz
Re: Review Request 35666: Add Better HDFS Error Handling
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35666/#review88579
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 19, 2015, 8:17 p.m., Erik Bergenholtz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35666/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 8:17 p.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12028
> https://issues.apache.org/jira/browse/AMBARI-12028
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Primary function of this patch is to add better HDFS error handling and retry in the case of a particular HDFS bug.
>
>
> Diffs
> -----
>
> contrib/views/hive/pom.xml 6cd7c09
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js b3cd127
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js 5ab46f6
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js d6ae8c4
> contrib/views/utils/pom.xml 76d04c7
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java 80603b5
>
> Diff: https://reviews.apache.org/r/35666/diff/
>
>
> Testing
> -------
>
> Ran Unit Tests for Hive and Utils + live deployment of view on cluster
>
> Hive:
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.502 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.123 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.1 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.274 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.509 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.196 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.6 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.236 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.358 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.624 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.126 sec
> Results :
> Tests run: 48, Failures: 0, Errors: 0, Skipped: 0
> Utils:
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.utils.ambari.RemoteClusterTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec
> Running org.apache.ambari.view.utils.ambari.URLStreamProviderBasicAuthTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec
> Running org.apache.ambari.view.utils.ViewUserLocalTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
> Running org.apache.ambari.view.utils.hdfs.ConfigurationBuilderTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.15 sec
> Results :
> Tests run: 17, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Erik Bergenholtz
>
>
Re: Review Request 35666: Add Better HDFS Error Handling
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35666/#review88577
-----------------------------------------------------------
Ship it!
Ship It!
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java (line 397)
<https://reviews.apache.org/r/35666/#comment141151>
Can `ugi` be `null`? Maybe _protect_ against that?
- Robert Levas
On June 19, 2015, 4:17 p.m., Erik Bergenholtz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35666/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 4:17 p.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12028
> https://issues.apache.org/jira/browse/AMBARI-12028
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Primary function of this patch is to add better HDFS error handling and retry in the case of a particular HDFS bug.
>
>
> Diffs
> -----
>
> contrib/views/hive/pom.xml 6cd7c09
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js b3cd127
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js 5ab46f6
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js d6ae8c4
> contrib/views/utils/pom.xml 76d04c7
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java 80603b5
>
> Diff: https://reviews.apache.org/r/35666/diff/
>
>
> Testing
> -------
>
> Ran Unit Tests for Hive and Utils + live deployment of view on cluster
>
> Hive:
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.502 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.123 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.1 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.274 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.509 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.196 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.6 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.236 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.358 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.624 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.126 sec
> Results :
> Tests run: 48, Failures: 0, Errors: 0, Skipped: 0
> Utils:
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.utils.ambari.RemoteClusterTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec
> Running org.apache.ambari.view.utils.ambari.URLStreamProviderBasicAuthTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec
> Running org.apache.ambari.view.utils.ViewUserLocalTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
> Running org.apache.ambari.view.utils.hdfs.ConfigurationBuilderTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.15 sec
> Results :
> Tests run: 17, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Erik Bergenholtz
>
>