[GitHub] [airflow] eladkal commented on a diff in pull request #29997: Return error when group is not defined in breeze configuration

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #29997:
URL: https://github.com/apache/airflow/pull/29997#discussion_r1131158069


##########
dev/breeze/src/airflow_breeze/commands/setup_commands.py:
##########
@@ -508,7 +508,7 @@ def check_params(command: str, subcommand: str | None, command_dict: dict[str, A
             f"defined in rich click configuration."
         )
         get_console().print(f"[warning]Please add it to the `{command_path_config(command)}`.")
-        return False
+        return True

Review Comment:
   It's kinda strange that for a function named `check_params` the return value of True means that something is wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org