Re: [PR] GH-39384: [C++] Disable -Werror=attributes for Azure SDK's identity.hpp [arrow]

["antkmsft (via GitHub)" <gi...@apache.org>]

antkmsft commented on PR #39448:
URL: https://github.com/apache/arrow/pull/39448#issuecomment-2654531862

   > > +1
   > > Could you report this to the upstream?
   > 
   > I read the code and I don't understand what is triggering the warning.
   
   I think it could be due to the fact that one of the class private data members (`UniquePrivateKey m_pkey`) uses a function in its destructor, which is defined only in Azure Identity's .cpp code and is not exported (`FreePrivateKeyImpl()`). However, since the code for the destructor of the class which contains that data member is also located in the same .cpp file, there is no problem - all the invocations of the function that is not exported is happening from the function that does get exported successfully, i.e. `~ClientCertificateCredential()` can call a destructor for `m_key`, which calls `FreePrivateKeyImpl()`, which is accessible from the .cpp file where `~ClientCertificateCredential()` lives. Users are not supposed to interact with `UniquePrivateKey` in any other way, but the compiler does not know that. That's my guess.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org