[GitHub] michellethomas opened a new pull request #3749: Removing empty filters from explore url

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #3749: Removing empty filters from explore url
URL: https://github.com/apache/incubator-superset/pull/3749
 
 
   We've been having issues with urls that are too long. This is one quick solution where getExploreUrl removes any filters where the value is empty. These seem to be getting added from the dashboard filters, but I don't believe they are needed.
   
   This will mean that even if an empty filter is set, it won't get saved to the slice. Is there any reason someone would need to set an empty filter?
   
   I tested creating and saving a slice with an empty filter. The filter does not get saved with the slice. On a dashboard a filter works with that slice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services