[GitHub] [spark] tgravescs edited a comment on pull request #31152: [SPARK-34089][CORE] MemoryConsumer should respect TaskMemoryManager's MemoryMode when the mode isn't explicitly set

[GitBox <gi...@apache.org>]

tgravescs edited a comment on pull request #31152:
URL: https://github.com/apache/spark/pull/31152#issuecomment-758703519


   so I'm a little confused by this. so I went back to the history. This seems to be used by Spillable, HashRelation, and RowQueue. It looks like at the time those were added, the MemoryConsumer didn't support a memory mode. 
   It looks like when that memory mode was added spilling was only support to on heap by Spillable (looking at the comment ing): https://github.com/apache/spark/commit/8fb1d1c7f3ed1b62625052a532b7388ebec71bbf
   Is that not the case now?
   Looking at:
   https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/collection/Spillable.scala#L111
   it seems like its only on heap.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org