You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/17 17:20:37 UTC

[GitHub] [kafka] hachikuji commented on a diff in pull request #12518: KAFKA-14167; Completion exceptions should not be translated directly to error codes

hachikuji commented on code in PR #12518:
URL: https://github.com/apache/kafka/pull/12518#discussion_r948229463


##########
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java:
##########
@@ -479,6 +482,19 @@ public static Errors forException(Throwable t) {
         return UNKNOWN_SERVER_ERROR;
     }
 
+    public static Throwable getCause(Throwable t) {

Review Comment:
   Yeah, let me try to think of a better name. One idea I was toying with is letting this method search the exception chain for the first ApiException. Then it doesn't need to be specific to CompletionException or ExecutionException. What do you think about that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org