You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/10 08:38:47 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request #14210: [Transaction] Move MetaStoreHandlerNotExistsException
liangyepianzhou opened a new pull request #14210:
URL: https://github.com/apache/pulsar/pull/14210
Master https://github.com/apache/pulsar/issues/13918
### Motivation & Modification
Makes exceptions on the Transaction client side clearer.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14210: [Transaction] Move MetaStoreHandlerNotExistsException
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14210:
URL: https://github.com/apache/pulsar/pull/14210#issuecomment-1079814973
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #14210: [Transaction] Move MetaStoreHandlerNotExistsException
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #14210:
URL: https://github.com/apache/pulsar/pull/14210#discussion_r813874517
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientException.java
##########
@@ -910,6 +910,20 @@ public TransactionConflictException(String msg) {
}
}
+ /**
+ * Thrown when transaction meta store handler not exists.
+ */
+ public static class MetaStoreHandlerNotExistsException extends PulsarClientException {
Review comment:
It's a confusing name, the `MetaStoreHandlerNotExistsException` sound like the client will connect to the metadata store, but the metadata store does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #14210: [Transaction] Move MetaStoreHandlerNotExistsException
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on a change in pull request #14210:
URL: https://github.com/apache/pulsar/pull/14210#discussion_r813895817
##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientException.java
##########
@@ -910,6 +910,20 @@ public TransactionConflictException(String msg) {
}
}
+ /**
+ * Thrown when transaction meta store handler not exists.
+ */
+ public static class MetaStoreHandlerNotExistsException extends PulsarClientException {
Review comment:
This exception is caused by `txnID.getMostSigBits()` > the actual number of TCs.
1. Change `MetaStoreHandlerNotExistsException` to `InvalidMetaStoreHandlerException` or `InvalidTxnIdException`
2. Because in a normal production environment, the situation where `mostSiqBits` is greater than the actual number of TCs will not occur. Consider removing `MetaStoreHandlerNotExistsException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org