[GitHub] dongjoon-hyun opened a new pull request #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4

[GitBox <gi...@apache.org>]

dongjoon-hyun opened a new pull request #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
URL: https://github.com/apache/spark/pull/23452
 
 
   ## What changes were proposed in this pull request?
   
   This PR upgrades Mockito from 1.10.19 to 2.23.4. The following changes are required.
   
   - Replace `org.mockito.Matchers` with `org.mockito.ArgumentMatchers`
   - Replace `anyObject` with `any`
   - Replace `getArgumentAt` with `getArgument` and add type annotation.
   - Use `isNull` matcher in case of `null` is invoked.
   ```scala
        saslHandler.channelInactive(null);
   -    verify(handler).channelInactive(any(TransportClient.class));
   +    verify(handler).channelInactive(isNull());
   ```
   
   - Make and use `doReturn` wrapper to avoid [SI-4775](https://issues.scala-lang.org/browse/SI-4775)
   ```
   private def doReturn(value: Any) = org.mockito.Mockito.doReturn(value, Seq.empty: _*)
   ```
   
   ## How was this patch tested?
   
   Pass the Jenkins with the existing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org