[GitHub] marcoabreu commented on a change in pull request #13549: Runtime feature detection

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #13549: Runtime feature detection
URL: https://github.com/apache/incubator-mxnet/pull/13549#discussion_r249293523
 
 

 ##########
 File path: python/mxnet/mxfeatures.py
 ##########
 @@ -0,0 +1,103 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# coding: utf-8
+# pylint: disable=not-an-iterable
+
+"""runtime detection of compile time features in the native library"""
+
+import ctypes
+import enum
+from .base import _LIB, check_call, mx_uint
+
+feature_names = [
 
 Review comment:
   Where was that list taken from (e.g. Makefile?)? Maybe we could have a script that we run in the sanity-check stage that ensures that this list of features is in sync with the source and otherwise prompt the contributor to add the feature.
   
   @ThomasDelteil did the same for tutorials

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services