You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by haohui <gi...@git.apache.org> on 2017/03/29 23:58:40 UTC
[GitHub] flink pull request #3648: [FLINK-6217] ContaineredTaskManagerParameters sets...
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3648
[FLINK-6217] ContaineredTaskManagerParameters sets off-heap memory size incorrectly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK-6217
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3648.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3648
----
commit 6da863509775d6f371acdecd706db5f3a7181bf2
Author: Haohui Mai <wh...@apache.org>
Date: 2017-03-29T23:57:52Z
[FLINK-6217] ContaineredTaskManagerParameters sets off-heap memory size incorrectly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3648
The test failure seems unrelated. Cannot reproduce locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3648
Good fix, thanks @haohui
I was wondering - I am a trying to advocate fewer dependencies in Flink (there is always the problem of shading and conflicts) so if there is a way to do this without Guava, that'd be great. I think `commons-lang3` has a joiner as well, or we might just add a joiner to Flink...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3648
The failed tests are being addressed in FLINK-6175.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3648: [FLINK-6217] ContaineredTaskManagerParameters sets...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3648
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3648
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3648
Thanks for your contribution @haohui and the review @StephanEwen. Changes look good to me. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3648: [FLINK-6217] ContaineredTaskManagerParameters sets off-he...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3648
Totally Agree :-) @StephanEwen please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---