You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/05 10:29:19 UTC

[GitHub] [buildstream] BuildStream-Migration-Bot opened a new issue #1402: Buildstream should refuse to build if disk space is too low.

BuildStream-Migration-Bot opened a new issue #1402:
URL: https://github.com/apache/buildstream/issues/1402


   [See original issue on GitLab](https://gitlab.com/BuildStream/buildstream/-/issues/1402)
   In GitLab by [[Gitlab user @tcanabrava]](https://gitlab.com/tcanabrava) on Oct 5, 2020, 13:41
   
   Because of an unrelated bug in buildstream I was locked out of my linux box: the cache filled up ~/ completely and not even login was possible. I do have a fairly sized drive but the cache was bigger, so we should warn the user (someway, somehow) that he does not have the required amount of space after build for the cached artifacts.
   
   We already have a feature to store the sha256 of the files, I propose a extension of that.
   ```
   element:
     ref: (sha256 here)
     download-size: - (automatically filled for the specific sha256)
     artifact-size: - (automatically filled for the specific sha265)
   ```
   
   of course this is impossible to have for the first build, but if we are using things as a external junction, this junction will have those element numbers, and buildstream can sum the necessary disk space for usage, and warn if the current size is too low before attempting a build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] gtristan closed issue #1402: Buildstream should refuse to build if disk space is too low.

Posted by GitBox <gi...@apache.org>.
gtristan closed issue #1402:
URL: https://github.com/apache/buildstream/issues/1402


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] BuildStream-Migration-Bot commented on issue #1402: Buildstream should refuse to build if disk space is too low.

Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on issue #1402:
URL: https://github.com/apache/buildstream/issues/1402#issuecomment-773065790






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] abderrahim commented on issue #1402: Buildstream should refuse to build if disk space is too low.

Posted by GitBox <gi...@apache.org>.
abderrahim commented on issue #1402:
URL: https://github.com/apache/buildstream/issues/1402#issuecomment-1042690886


   This is mitigated in bst-2 anyway, as buildbox-casd will start cleanup when disk space runs low. bst-1 would simply let the build crash onto the "No space left on device" wall.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] gtristan commented on issue #1402: Buildstream should refuse to build if disk space is too low.

Posted by GitBox <gi...@apache.org>.
gtristan commented on issue #1402:
URL: https://github.com/apache/buildstream/issues/1402#issuecomment-1042595562


   Note that the reporter was asking for a build to fail before starting if there is 100GB available in the local cache but the build will cost 110GB.
   
   Currently BuildStream will simply *do it's best* and has no concept or method to predict how much disk space an element will cost in advance of building it, and I don't expect that to reasonably change.
   
   I'll mark this as WONTFIX and we can revisit in some hypothetical future when users have the ability to annotate elements with resource requirement annotations, or some approach which could plausibly address this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] abderrahim commented on issue #1402: Buildstream should refuse to build if disk space is too low.

Posted by GitBox <gi...@apache.org>.
abderrahim commented on issue #1402:
URL: https://github.com/apache/buildstream/issues/1402#issuecomment-791908601


   The OP didn't state whether this is bst 1 or bst 2, but I think this is bst 1.
   
   My overall experience is that bst 2 is way better than bst 1 at this. It will correctly clean up its cache and keep the headroom, and even interrupt the build if there is no available space.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org