You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "mihaibudiu (via GitHub)" <gi...@apache.org> on 2026/08/04 18:29:17 UTC
[PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
mihaibudiu opened a new pull request, #314:
URL: https://github.com/apache/calcite-avatica/pull/314
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5563578122
As I understand it, the issue is simply that Avatica was losing the "UTC" designation, so the goal of this PR (including the tests) is to verify that the fix preserves that designation. Therefore, there is no need to verify the correctness of the time zone handling itself (such as in the example below)—is that correct?
```
select TIMESTAMP WITH TIME ZONE '2020-01-01 00:00:00 America/New_York';
+---------------------+
| EXPR$0 |
+---------------------+
| 2020-01-01 05:00:00 |
+---------------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5183165911
This fails in CI because it affects the output of some Calcite tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5564931228
Yes, this is right. This will need to be merged in 3 steps: disable calcite tests, merge this, enable calcite tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5247376157
Whoever is reviewing this, please also check the failing CI test output, since it shows what the Calcite results will be in the future if we merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu merged PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5184316178
This affects the Calcite output, causing CI to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5574370181
@F21 once we merge https://github.com/apache/calcite/pull/5247 we can hopefully merge this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5247222109
I guess I should first submit a helper PR in Calcite to disable the failing tests, and after merging this we can re-enable them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7494] Avatica conversion to string of TIMESTAMP WITH TIME ZONE does not include time zone [calcite-avatica]
Posted by "F21 (via GitHub)" <gi...@apache.org>.
F21 commented on PR #314:
URL: https://github.com/apache/calcite-avatica/pull/314#issuecomment-5570454035
@mihaibudiu I can see that @xiedeyantu has approved this PR. Can you go ahead with the required merges to get this in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org