You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "leixm (via GitHub)" <gi...@apache.org> on 2023/02/10 07:17:08 UTC

[GitHub] [incubator-uniffle] leixm opened a new issue, #587: [Subtask] [Netty] Coordinator supports netty

leixm opened a new issue, #587:
URL: https://github.com/apache/incubator-uniffle/issues/587

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues) and found no similar issues.
   
   
   ### Describe the subtask
   
   Rewrite the grpc interface in Coordinator using a custom serialization/deserialization protocol.
   The document link address is as follows:
   https://docs.google.com/document/d/1srlBlLpJ3hbzd8ru5QaY5aCSLR9M2ttHXmlvcFC-SLg/edit?usp=sharing
   
   ### Parent issue
   
   https://github.com/apache/incubator-uniffle/issues/133
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] leixm commented on issue #587: [Subtask] [Netty] Coordinator supports netty

Posted by "leixm (via GitHub)" <gi...@apache.org>.
leixm commented on issue #587:
URL: https://github.com/apache/incubator-uniffle/issues/587#issuecomment-1425304873

   The communication protocols of the coordinator and the shuffleserver are different, which looks a bit weird. Of course, this is not a high priority.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #587: [Subtask] [Netty] Coordinator supports netty

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #587:
URL: https://github.com/apache/incubator-uniffle/issues/587#issuecomment-1425411428

   > The communication protocols of the coordinator and the shuffleserver are different, which looks a bit weird. Of course, this is not a high priority.
   
   We only need to replace data transfer api like Spark. Spark use Rpc and Netty at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on issue #587: [Subtask] [Netty] Coordinator supports netty

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #587:
URL: https://github.com/apache/incubator-uniffle/issues/587#issuecomment-1425507862

   This should be a low priority task. If we have enough time and resource, we could replace gRPC with netty.
   
   > We only need to replace data transfer api like Spark. Spark use Rpc and Netty at the same time.
   
   To clarify a bit: in my understanding, spark only uses netty to rpc service.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] leixm commented on issue #587: [Subtask] [Netty] Coordinator supports netty

Posted by "leixm (via GitHub)" <gi...@apache.org>.
leixm commented on issue #587:
URL: https://github.com/apache/incubator-uniffle/issues/587#issuecomment-1425413007

   It's ok for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] jerqi commented on issue #587: [Subtask] [Netty] Coordinator supports netty

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #587:
URL: https://github.com/apache/incubator-uniffle/issues/587#issuecomment-1425300964

   Why do we need modify the coordinator?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org