You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/02 23:43:07 UTC

[GitHub] [arrow] domoritz commented on a change in pull request #12718: ARROW-16099: [JS] RecordBatches that are compressed should throw an error

domoritz commented on a change in pull request #12718:
URL: https://github.com/apache/arrow/pull/12718#discussion_r841131656



##########
File path: js/src/ipc/metadata/message.ts
##########
@@ -297,6 +297,9 @@ function decodeSchema(_schema: _Schema, dictionaries: Map<number, DataType> = ne
 
 /** @ignore */
 function decodeRecordBatch(batch: _RecordBatch, version = MetadataVersion.V4) {
+    if (batch.compression() !== null) {
+        throw new Error("Record batch compression not implemented");

Review comment:
       ```suggestion
           throw new Error('Record batch compression not implemented');
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org