You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by David Blevins <da...@gmail.com> on 2011/09/28 09:53:55 UTC
Re: svn commit: r1176770 - /openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
On Sep 28, 2011, at 12:45 AM, andygumbrecht@apache.org wrote:
> Author: andygumbrecht
> Date: Wed Sep 28 07:45:20 2011
> New Revision: 1176770
>
> URL: http://svn.apache.org/viewvc?rev=1176770&view=rev
> Log:
> Fix typo
>
> Modified:
> openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
>
> Modified: openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
> URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java?rev=1176770&r1=1176769&r2=1176770&view=diff
> ==============================================================================
> --- openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java (original)
> +++ openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java Wed Sep 28 07:45:20 2011
> @@ -72,7 +72,7 @@ import javax.xml.bind.annotation.adapter
>
> @XmlAccessorType(XmlAccessType.FIELD)
> @XmlType(name = "data-sourceType", propOrder = {
> - "descriptions",
> + "description",
> "name",
> "className",
> "serverName",
Think we also need to update the property itself. (see buildbot failure [1])
-David
[1] http://ci.apache.org/builders/openejb-trunk-ubuntu/builds/1223/steps/test-results/logs/stdio
Re: svn commit: r1176770 - /openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
Posted by David Blevins <da...@gmail.com>.
On Sep 28, 2011, at 2:25 AM, AndyG wrote:
> Just reverted, but shouldn't we really have a DescriptionType[] for this?
I haven't looked closely at the schema for DataSource. Some of the other "description" types allow for localized descriptions. If this one does too, maybe we should use the 'protected TextMap description = new TextMap();' technique like a few other places.
-David
Re: svn commit: r1176770 -
/openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
Posted by AndyG <an...@orprovision.com>.
Just reverted, but shouldn't we really have a DescriptionType[] for this?
--
View this message in context: http://openejb.979440.n4.nabble.com/Re-svn-commit-r1176770-openejb-trunk-openejb3-container-openejb-jee-src-main-java-org-apache-openejba-tp3850280p3850508.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: svn commit: r1176770 - /openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
Posted by Andy <an...@orprovision.com>.
On 28.09.2011 09:53, David Blevins wrote:
> On Sep 28, 2011, at 12:45 AM, andygumbrecht@apache.org wrote:
>
>> Author: andygumbrecht
>> Date: Wed Sep 28 07:45:20 2011
>> New Revision: 1176770
>>
>> URL: http://svn.apache.org/viewvc?rev=1176770&view=rev
>> Log:
>> Fix typo
>>
>> Modified:
>> openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
>>
>> Modified: openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java
>> URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java?rev=1176770&r1=1176769&r2=1176770&view=diff
>> ==============================================================================
>> --- openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java (original)
>> +++ openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/DataSource.java Wed Sep 28 07:45:20 2011
>> @@ -72,7 +72,7 @@ import javax.xml.bind.annotation.adapter
>>
>> @XmlAccessorType(XmlAccessType.FIELD)
>> @XmlType(name = "data-sourceType", propOrder = {
>> - "descriptions",
>> + "description",
>> "name",
>> "className",
>> "serverName",
> Think we also need to update the property itself. (see buildbot failure [1])
>
>
> -David
>
> [1] http://ci.apache.org/builders/openejb-trunk-ubuntu/builds/1223/steps/test-results/logs/stdio
>
>
>
Thanks David, on it already - silly mistake