[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #197: Wait for another reconcile request to fix flaky test in CI

[GitBox <gi...@apache.org>]

thelabdude commented on a change in pull request #197:
URL: https://github.com/apache/lucene-solr-operator/pull/197#discussion_r562762422



##########
File path: controllers/solrprometheusexporter_controller_test.go
##########
@@ -656,10 +657,14 @@ func TestMetricsReconcileWithUserProvidedConfig(t *testing.T) {
 	updatedConfigXml := "<config>updated by user</config>"
 	updateUserProvidedConfigMap(testClient, g, userProvidedConfigMapNN, map[string]string{util.PrometheusExporterConfigMapKey: updatedConfigXml})
 
-	// reconcile should happen again
+	// reconcile should happen again 2x
 	g.Eventually(requests, timeout).Should(gomega.Receive(gomega.Equal(expectedMetricsRequest)))
+	g.Eventually(requests, timeout).Should(gomega.Receive(gomega.Equal(expectedMetricsRequest)))
+
+	deployment = &appsv1.Deployment{}
+	err = testClient.Get(context.TODO(), metricsDKey, deployment)
+	g.Expect(err).NotTo(gomega.HaveOccurred())
 
-	deployment = expectDeployment(t, g, requests, expectedMetricsRequest, metricsDKey, userProvidedConfigMap.Name)

Review comment:
       that was me just trying to simplify test logic but I changed it back




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org