You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by li...@apache.org on 2009/01/06 16:48:07 UTC

svn commit: r731980 - /geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandListConfigurations.java

Author: linsun
Date: Tue Jan  6 07:48:06 2009
New Revision: 731980

URL: http://svn.apache.org/viewvc?rev=731980&view=rev
Log:
GERONIMO-4491 Can not assemble application centric custom server if there is deployed application, which is not converted into plugin

Modified:
    geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandListConfigurations.java

Modified: geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandListConfigurations.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandListConfigurations.java?rev=731980&r1=731979&r2=731980&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandListConfigurations.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandListConfigurations.java Tue Jan  6 07:48:06 2009
@@ -41,7 +41,6 @@
 import org.apache.geronimo.kernel.config.NoSuchStoreException;
 import org.apache.geronimo.system.plugin.DownloadResults;
 import org.apache.geronimo.system.plugin.PluginInstallerGBean;
-import org.apache.geronimo.system.plugin.SourceRepository;
 import org.apache.geronimo.system.plugin.model.PluginArtifactType;
 import org.apache.geronimo.system.plugin.model.PluginListType;
 import org.apache.geronimo.system.plugin.model.PluginType;
@@ -324,14 +323,11 @@
                     }
                 }
             }
-            if (plugin == null) {
-                throw new IllegalStateException("No configuration found for '" + configId + "'");
-            }
+            // if plugin value is null here, means the configId is not a geronimo plugin - ignore
         }
         return installList;
     }
 
-
     public void assembleServer(GeronimoDeploymentManager mgr, PluginListType list, String repositoryPath, String relativeServerPath, ConsoleReader consoleReader) throws Exception {
         long start = System.currentTimeMillis();
         DownloadResults results = mgr.installPluginList(repositoryPath, relativeServerPath, list);