You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/10/03 19:54:40 UTC
Re: Review Request 25972: Make thermos more cognizant of user
deletions
> On Sept. 24, 2014, 10:43 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/thermos/core/helper.py, line 97
> > <https://reviews.apache.org/r/25972/diff/1/?file=703794#file703794line97>
> >
> > nullable as well?
No -- the username is still checked at the beginning and will always be available (even in legacy thermos checkpoint records.) If the username doesn't exist, we fail early, so we'll never make it here with a null username.
> On Sept. 24, 2014, 10:43 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/thermos/core/test_helper.py, line 54
> > <https://reviews.apache.org/r/25972/diff/1/?file=703798#file703798line54>
> >
> > why does this need to be a contextmanager?
i have no idea why it's a contextmanager. fixed.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25972/#review54470
-----------------------------------------------------------
On Sept. 24, 2014, 12:58 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25972/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 12:58 a.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is changes 1 of 2 for AURORA-175. The second change adds an exit status contract between Aurora and Thermos.
>
> This change allows a process in the Thermos state machine to go directly from WAITING -> FAILED if the user associated with that process has been deleted. It also persists a 'uid' field to the Thermos RunnerHeader so that we can check against process UIDs which in theory have higher fidelity than usernames.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/common/ckpt.py 7df179b135e896d52655667f0707850a4bc33068
> src/main/python/apache/thermos/core/helper.py 82c68f3af424d3309db3816080465edd1ff1a87c
> src/main/python/apache/thermos/core/process.py 4889e636c2fa7325852684cecd87a2123714144d
> src/main/python/apache/thermos/core/runner.py 31f40713ec32c0626566899caec76f2a9985c7bf
> src/main/thrift/org/apache/thermos/thermos_internal.thrift 0cea1057230b367c9d55b773854453cee2f9fce0
> src/test/python/apache/thermos/core/test_helper.py 53f1e467283b45598b3f1865951c42b13579a512
> src/test/python/apache/thermos/core/test_process.py 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1
>
> Diff: https://reviews.apache.org/r/25972/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brian Wickman
>
>