You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/04/23 06:55:48 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2219: Issue #2212: Fix issues in Bookkeeper Docker image that prevented containers from starting up

eolivelli commented on a change in pull request #2219:
URL: https://github.com/apache/bookkeeper/pull/2219#discussion_r413558439



##########
File path: docker/scripts/init_bookie.sh
##########
@@ -19,65 +19,57 @@
 # * See the License for the specific language governing permissions and
 # * limitations under the License.
 # */
-
 source ${SCRIPTS_DIR}/common.sh
 
 function wait_for_zookeeper() {
     echo "wait for zookeeper"
-    until /opt/bookkeeper/bin/bookkeeper org.apache.zookeeper.ZooKeeperMain -server ${BK_zkServers} ls /; do sleep 5; done
+    until zk-shell --run-once "ls /" ${BK_zkServers}; do sleep 5; done

Review comment:
       In order to fix the integration tests I guess we should use the full path of zk-shell.
   In fact the previous line used the full path
   
   @dmercuriali can you please help fixing this patch fro @ravisharda  ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org