[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581397394



##########
File path: scripts/run-e2e-tests.sh
##########
@@ -69,24 +124,32 @@ function install_cluster() {
 
   echo "step 2/6: installing helm-v3"
   check_cmd "curl"
-  curl -L https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
-  exit_on_error "install helm-v3 failed"
-  check_cmd "helm"
+  if ! command -v helm &> /dev/null
+  then
+      install_helm
+  else
+    echo "Helm already installed"
+  fi

Review comment:
       just a small suggestion, the check can be added in the `install_helm` function, which makes the main flow simpler.
   same as the rest install functions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org