You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Mark Gellings (JIRA)" <ji...@apache.org> on 2009/12/14 19:40:52 UTC
[jira] Created: (AMQNET-224) Make RedeliveryPolicy.RedeliveryDelay
a virtual method so that it can be overridden
Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden
-----------------------------------------------------------------------------------
Key: AMQNET-224
URL: https://issues.apache.org/activemq/browse/AMQNET-224
Project: ActiveMQ .Net
Issue Type: Improvement
Components: ActiveMQ
Affects Versions: 1.2.0
Environment: ActiveMQ 5.2
Reporter: Mark Gellings
Assignee: Jim Gomes
Priority: Minor
Fix For: 1.2.0
Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden. We have enhanced redelivery logic to include optimistic and pessimistic client ack redeliveries. Would be nice if we could encapsulate this into the RedeliveryDelay method. By default java methods are virtual so this shouldn't be a problem IMO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-224) Make
RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be
overridden
Posted by "Mark Gellings (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56442#action_56442 ]
Mark Gellings commented on AMQNET-224:
--------------------------------------
That could work too. Would just be a bit cleaner to be able to reuse the base logic calling base.RedeliveryDelay if in Transactional acknowledgement mode rather than newing up another instance of RedeliveryPolicy to get the default delay back.
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden
> -----------------------------------------------------------------------------------
>
> Key: AMQNET-224
> URL: https://issues.apache.org/activemq/browse/AMQNET-224
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: ActiveMQ
> Affects Versions: 1.2.0
> Environment: ActiveMQ 5.2
> Reporter: Mark Gellings
> Assignee: Jim Gomes
> Priority: Minor
> Fix For: 1.2.0
>
>
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden. We have enhanced redelivery logic to include optimistic and pessimistic client ack redeliveries. Would be nice if we could encapsulate this into the RedeliveryDelay method. By default java methods are virtual so this shouldn't be a problem IMO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQNET-224) Make RedeliveryPolicy.RedeliveryDelay
a virtual method so that it can be overridden
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQNET-224.
---------------------------------
Resolution: Fixed
Change applied to trunk and NMS 1.2.x branch
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden
> -----------------------------------------------------------------------------------
>
> Key: AMQNET-224
> URL: https://issues.apache.org/activemq/browse/AMQNET-224
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: ActiveMQ
> Affects Versions: 1.2.0
> Environment: ActiveMQ 5.2
> Reporter: Mark Gellings
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 1.2.0
>
>
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden. We have enhanced redelivery logic to include optimistic and pessimistic client ack redeliveries. Would be nice if we could encapsulate this into the RedeliveryDelay method. By default java methods are virtual so this shouldn't be a problem IMO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQNET-224) Make
RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be
overridden
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56440#action_56440 ]
Timothy Bish commented on AMQNET-224:
-------------------------------------
Why don't you just create your own implementation of IRedeliveryPolicy and set that on the Connection object?
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden
> -----------------------------------------------------------------------------------
>
> Key: AMQNET-224
> URL: https://issues.apache.org/activemq/browse/AMQNET-224
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: ActiveMQ
> Affects Versions: 1.2.0
> Environment: ActiveMQ 5.2
> Reporter: Mark Gellings
> Assignee: Jim Gomes
> Priority: Minor
> Fix For: 1.2.0
>
>
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden. We have enhanced redelivery logic to include optimistic and pessimistic client ack redeliveries. Would be nice if we could encapsulate this into the RedeliveryDelay method. By default java methods are virtual so this shouldn't be a problem IMO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQNET-224) Make RedeliveryPolicy.RedeliveryDelay
a virtual method so that it can be overridden
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQNET-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish reassigned AMQNET-224:
-----------------------------------
Assignee: Timothy Bish (was: Jim Gomes)
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden
> -----------------------------------------------------------------------------------
>
> Key: AMQNET-224
> URL: https://issues.apache.org/activemq/browse/AMQNET-224
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: ActiveMQ
> Affects Versions: 1.2.0
> Environment: ActiveMQ 5.2
> Reporter: Mark Gellings
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 1.2.0
>
>
> Make RedeliveryPolicy.RedeliveryDelay a virtual method so that it can be overridden. We have enhanced redelivery logic to include optimistic and pessimistic client ack redeliveries. Would be nice if we could encapsulate this into the RedeliveryDelay method. By default java methods are virtual so this shouldn't be a problem IMO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.