You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Thomas Bennett <lm...@gmail.com> on 2012/04/12 15:33:57 UTC
Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/
-----------------------------------------------------------
Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
Summary
-------
String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
This addresses bug OODT-440.
https://issues.apache.org/jira/browse/OODT-440
Diffs
-----
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
Diff: https://reviews.apache.org/r/4709/diff
Testing
-------
Unit test pass
Works on my installed OODT ditribution
Thanks,
Thomas
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6997
-----------------------------------------------------------
Ship it!
LGTM.
- Chris
On 2012-04-17 14:36:54, Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> -----------------------------------------------------------
>
> (Updated 2012-04-17 14:36:54)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
>
>
> Summary
> -------
>
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
>
>
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
>
> Diff: https://reviews.apache.org/r/4709/diff
>
>
> Testing
> -------
>
> Unit test pass
> Works on my installed OODT ditribution
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Thomas Bennett <lm...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/
-----------------------------------------------------------
(Updated 2012-04-17 14:36:54.936567)
Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
Changes
-------
Added all suggested changes. Thanks for the extra uuid catch.
Summary
-------
String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
This addresses bug OODT-440.
https://issues.apache.org/jira/browse/OODT-440
Diffs (updated)
-----
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
Diff: https://reviews.apache.org/r/4709/diff
Testing
-------
Unit test pass
Works on my installed OODT ditribution
Thanks,
Thomas
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Sheryl John <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6910
-----------------------------------------------------------
Ship it!
Nice catch! Looks good. Note the "uuid" too.
- Sheryl
On 2012-04-12 13:33:57, Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 13:33:57)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
>
>
> Summary
> -------
>
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
>
>
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
>
> Diff: https://reviews.apache.org/r/4709/diff
>
>
> Testing
> -------
>
> Unit test pass
> Works on my installed OODT ditribution
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Paul Ramirez <pr...@jpl.nasa.gov>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6897
-----------------------------------------------------------
Ship it!
Other than what the other 2 commenters already mentioned LGTM.
- Paul
On 2012-04-12 13:33:57, Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 13:33:57)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
>
>
> Summary
> -------
>
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
>
>
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
>
> Diff: https://reviews.apache.org/r/4709/diff
>
>
> Testing
> -------
>
> Unit test pass
> Works on my installed OODT ditribution
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Ricky Nguyen <ri...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6891
-----------------------------------------------------------
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java
<https://reviews.apache.org/r/4709/#comment15335>
How about using CoreMetKeys.PRODUCT_ID ?
- Ricky
On 2012-04-12 13:33:57, Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 13:33:57)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
>
>
> Summary
> -------
>
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
>
>
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
>
> Diff: https://reviews.apache.org/r/4709/diff
>
>
> Testing
> -------
>
> Unit test pass
> Works on my installed OODT ditribution
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6881
-----------------------------------------------------------
Ship it!
LGTM!
- Chris
On 2012-04-12 13:33:57, Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 13:33:57)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
>
>
> Summary
> -------
>
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
>
>
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
>
> Diff: https://reviews.apache.org/r/4709/diff
>
>
> Testing
> -------
>
> Unit test pass
> Works on my installed OODT ditribution
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6909
-----------------------------------------------------------
Ship it!
- Chris
On 2012-04-12 13:33:57, Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 13:33:57)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
>
>
> Summary
> -------
>
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
>
>
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
>
> Diff: https://reviews.apache.org/r/4709/diff
>
>
> Testing
> -------
>
> Unit test pass
> Works on my installed OODT ditribution
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: String search and replace getMetadata("UUID with
getMetadata("CAS.ProductId
Posted by Ricky Nguyen <ri...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4709/#review6892
-----------------------------------------------------------
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java
<https://reviews.apache.org/r/4709/#comment15336>
i think paul mentioned this "uuid" too
- Ricky
On 2012-04-12 13:33:57, Thomas Bennett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4709/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 13:33:57)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John.
>
>
> Summary
> -------
>
> String search and replace getMetadata("UUID with getMetadata("CAS.ProductId
>
>
> This addresses bug OODT-440.
> https://issues.apache.org/jira/browse/OODT-440
>
>
> Diffs
> -----
>
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745
>
> Diff: https://reviews.apache.org/r/4709/diff
>
>
> Testing
> -------
>
> Unit test pass
> Works on my installed OODT ditribution
>
>
> Thanks,
>
> Thomas
>
>