[GitHub] [skywalking-java] lujiajing1126 commented on pull request #467: Fix thrift plugin generate duplicate traceid

["lujiajing1126 (via GitHub)" <gi...@apache.org>]

lujiajing1126 commented on PR #467:
URL: https://github.com/apache/skywalking-java/pull/467#issuecomment-1452928949

   > In thrift plugin，it generate span before sendBase method and stop this span after receiveBase. However, if an error occurs in sendBase method, this thrift-client span will not be stopped, which leads to the tracecontext can not be cleaned properly. Therefore, we stop the span in the handldException method around sendBase method.
   
   If so, we may choose an improper interception point.
   
   I'm not familiar with thrift. But If you stop the span in the `handleMethodException`, can you make sure this span will not be stopped again in the after hook of the so-called `receiveBase` method. If the span is closed twice, it may cause undefined behavior and thus break the full stacked-base tracing subsystem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org