You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/25 21:30:33 UTC
[GitHub] [airflow] potiuk opened a new pull request #10566: Move dag's cli method out of DAG.
potiuk opened a new pull request #10566:
URL: https://github.com/apache/airflow/pull/10566
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10566: Move dag's cli method out of DAG.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10566:
URL: https://github.com/apache/airflow/pull/10566#issuecomment-680299004
But If you want to remove it - feel free :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #10566: Move dag's cli method out of DAG.
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10566:
URL: https://github.com/apache/airflow/pull/10566#issuecomment-706789486
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10566: Move dag's cli method out of DAG.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10566:
URL: https://github.com/apache/airflow/pull/10566#issuecomment-680298754
> I wonder if it would be better to delete it. This was helpful when it was easy available, but that leads to a lot of problems. The basic thing is that we have to support running DAGs that have not been loaded by DagBag, so we have to do many things when `import airflow` e.g. add new path to sys.path, loading plugins, etc. If we do not prepare the environment while the airflow import is being done, loading the DAG File may fail.
Maybe as a next move. For now I want to focus on deps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #10566: Move dag's cli method out of DAG.
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #10566:
URL: https://github.com/apache/airflow/pull/10566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10566: Move dag's cli method out of DAG.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10566:
URL: https://github.com/apache/airflow/pull/10566#issuecomment-680307447
We may think about it later. This change now needs an entry in UPDATING.md anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #10566: Move dag's cli method out of DAG.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10566:
URL: https://github.com/apache/airflow/pull/10566#issuecomment-680284178
I wonder if it would be better to delete it. This was helpful when it was easy available, but that leads to a lot of problems. The basic thing is that we have to support running DAGs that have not been loaded by DagBag, so we have to do many things when ``import airflow`` e.g. add new path to sys.path, loading plugins, etc. If we do not prepare the environment while the airflow import is being done, loading the DAG File may fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org