[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6595: fix: from_plan shouldn't use original schema & simplify expression need to convert type.

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6595:
URL: https://github.com/apache/arrow-datafusion/pull/6595#discussion_r1225815262


##########
datafusion/common/src/dfschema.rs:
##########
@@ -384,8 +384,7 @@ impl DFSchema {
         let self_fields = self.fields().iter();
         let other_fields = other.fields().iter();
         self_fields.zip(other_fields).all(|(f1, f2)| {
-            f1.qualifier() == f2.qualifier()
-                && f1.name() == f2.name()
+            f1.qualified_name() == f2.qualified_name()

Review Comment:
   About this, I have a new idea on weekend. we may need an `alias_with_schema()` function that allows us to not only add alias, but also specify the schema.
   
   Because `alias('t1.a')`, `field` is `qualifier: none, name: t1.a`, we hope `field` is `qualifier: t1, name: a`.
   
   I think `alias_with_schema()` can achieve this goal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org