[GitHub] [hbase] belugabehr commented on a change in pull request #927: HBASE-23556: Minor ChoreService Cleanup

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #927: HBASE-23556: Minor ChoreService Cleanup
URL: https://github.com/apache/hbase/pull/927#discussion_r356243517
 
 

 ##########
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
 ##########
 @@ -173,9 +173,7 @@ public synchronized boolean scheduleChore(ScheduledChore chore) {
    * @param chore The Chore to be rescheduled. If the chore is not scheduled with this ChoreService
    *          yet then this call is equivalent to a call to scheduleChore.
    */
-  private synchronized void rescheduleChore(ScheduledChore chore) {
-    if (chore == null) return;
-
 
 Review comment:
   This is a private method.  The public methods that call this are already synchronized and already ensure that 'chore' is not null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services