You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2011/07/11 14:58:00 UTC
[jira] [Created] (SLING-2134) Provide a way to add additional
properties to sling.properties
Provide a way to add additional properties to sling.properties
--------------------------------------------------------------
Key: SLING-2134
URL: https://issues.apache.org/jira/browse/SLING-2134
Project: Sling
Issue Type: New Feature
Components: Maven Plugins and Archetypes
Affects Versions: Maven Launchpad Plugin 2.0.10
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
Fix For: Maven Launchpad Plugin 2.1.0
Currently the sling.properties from launchpad.base are used as is. We should have a way to add addtional properties.
Not sure if we need removal?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2134) Provide a way to add additional
properties to sling.properties
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092670#comment-13092670 ]
Carsten Ziegeler commented on SLING-2134:
-----------------------------------------
Renamed the properties file to "common.properties" in Revision: 1162656
I think this is a better name and in addition it allows us to have something like webapp.properties, standalone.properties later on if we need them
> Provide a way to add additional properties to sling.properties
> --------------------------------------------------------------
>
> Key: SLING-2134
> URL: https://issues.apache.org/jira/browse/SLING-2134
> Project: Sling
> Issue Type: New Feature
> Components: Maven Plugins and Archetypes
> Affects Versions: Maven Launchpad Plugin 2.0.10
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Maven Launchpad Plugin 2.1.0
>
>
> Currently the sling.properties from launchpad.base are used as is. We should have a way to add addtional properties.
> Not sure if we need removal?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Resolved] (SLING-2134) Provide a way to add additional properties to sling.properties
Posted by Justin Edelson <ju...@justinedelson.com>.
Carsten-
Could you document this feature on the plugin page if you haven't already?
I need to do the same for partial lists, but I'm still not sure that's fully implemented.
Thanks,
Justin
On Jul 13, 2011, at 8:14 AM, "Carsten Ziegeler (JIRA)" <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/SLING-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Carsten Ziegeler resolved SLING-2134.
> -------------------------------------
>
> Resolution: Fixed
>
> Updated the implementation with revision 1145965:
>
> The props is now in src/main/sling/additional.properties
>
> I've also added support for filtering
>
>> Provide a way to add additional properties to sling.properties
>> --------------------------------------------------------------
>>
>> Key: SLING-2134
>> URL: https://issues.apache.org/jira/browse/SLING-2134
>> Project: Sling
>> Issue Type: New Feature
>> Components: Maven Plugins and Archetypes
>> Affects Versions: Maven Launchpad Plugin 2.0.10
>> Reporter: Carsten Ziegeler
>> Assignee: Carsten Ziegeler
>> Fix For: Maven Launchpad Plugin 2.1.0
>>
>>
>> Currently the sling.properties from launchpad.base are used as is. We should have a way to add addtional properties.
>> Not sure if we need removal?
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Resolved] (SLING-2134) Provide a way to add additional
properties to sling.properties
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2134.
-------------------------------------
Resolution: Fixed
Updated the implementation with revision 1145965:
The props is now in src/main/sling/additional.properties
I've also added support for filtering
> Provide a way to add additional properties to sling.properties
> --------------------------------------------------------------
>
> Key: SLING-2134
> URL: https://issues.apache.org/jira/browse/SLING-2134
> Project: Sling
> Issue Type: New Feature
> Components: Maven Plugins and Archetypes
> Affects Versions: Maven Launchpad Plugin 2.0.10
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Maven Launchpad Plugin 2.1.0
>
>
> Currently the sling.properties from launchpad.base are used as is. We should have a way to add addtional properties.
> Not sure if we need removal?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2134) Provide a way to add additional
properties to sling.properties
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063318#comment-13063318 ]
Carsten Ziegeler commented on SLING-2134:
-----------------------------------------
I've committed a first implementation in revision: 1145156
It looks for a sling.properties under src/main/config and adds these properties.
This works, but has the drawback that now sling.properties is added as a configuration as well.
I also think that the name sling.properties is wrong - as this is just an additional file.
Still not sure if we need properties removal.
> Provide a way to add additional properties to sling.properties
> --------------------------------------------------------------
>
> Key: SLING-2134
> URL: https://issues.apache.org/jira/browse/SLING-2134
> Project: Sling
> Issue Type: New Feature
> Components: Maven Plugins and Archetypes
> Affects Versions: Maven Launchpad Plugin 2.0.10
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Maven Launchpad Plugin 2.1.0
>
>
> Currently the sling.properties from launchpad.base are used as is. We should have a way to add addtional properties.
> Not sure if we need removal?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira