[GitHub] [skywalking] wu-sheng edited a comment on pull request #6686: Add Dockerfile and build script for Java agent Docker image

[GitBox <gi...@apache.org>]

wu-sheng edited a comment on pull request #6686:
URL: https://github.com/apache/skywalking/pull/6686#issuecomment-814121786


   > > > I'm just suggesting, if we want to provide agent image, we provide a useable one, instead of a simple wrapper of the agent jars.
   > > 
   > > 
   > > My idea is, the recommended way should not be the base image. The agent jar image should be used as a sidecar's image, which should attach on the main image belong to the user.
   > 
   > I've never planned that this Docker image is designed **ONLY** for uses under Kubernetes. This is a prerequisite of my thoughts, does it work for you? If so:
   > 
   > here is 2 typical uses of this image:
   > 
   > * Traditional Docker deployment, something simply like `docker run application-based-on-this-agent`, or `docker-compose up`, under this scenario, building our agent based on `openjdk 8 / openjdk 11` is extremely helpful for users, read [#6686 (comment)](https://github.com/apache/skywalking/pull/6686#issuecomment-813799007) for the detailed usage.
   > * In Kubernetes as a sidecar, where we definitely can have an minimized image, say `apache/skywalking-java-agent:8.5.0-sidecar`, which based on `scratch / alpine`, and mounts the agent dir into the Pod where the main image resides.
   > 
   > All of these 2 usages can be documented in repo [http://github.com/apache/skywalking-docker/](https://github.com/apache/skywalking-docker/) and I'll document them in [apache/skywalking-docker#17](https://github.com/apache/skywalking-docker/pull/17) if 👆 makes sense to you
   
   Make sense to me. Should we make two different images or three(jdk8/jdk11 base and sidecar) in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org