You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Funk (JIRA)" <ji...@apache.org> on 2007/08/22 14:12:31 UTC
[jira] Created: (WICKET-871) Markup hirarchy gets messed up when
value of attribute 'background' is a relative path
Markup hirarchy gets messed up when value of attribute 'background' is a relative path
---------------------------------------------------------------------------------------
Key: WICKET-871
URL: https://issues.apache.org/jira/browse/WICKET-871
Project: Wicket
Issue Type: Bug
Reporter: Martin Funk
$ svn diff -r HEAD
Index: src/main/java/org/apache/wicket/quickstart/Index.java
===================================================================
--- src/main/java/org/apache/wicket/quickstart/Index.java (Revision 568574)
+++ src/main/java/org/apache/wicket/quickstart/Index.java (Arbeitskopie)
@@ -17,6 +17,7 @@
package org.apache.wicket.quickstart;
import org.apache.wicket.PageParameters;
+import org.apache.wicket.markup.html.basic.Label;
/**
* Basic bookmarkable index page.
@@ -35,5 +36,6 @@
*/
public Index(final PageParameters parameters)
{
+ this.add(new Label("myname", "Whishing that this is not a bug."));
}
}
Index: src/main/java/org/apache/wicket/quickstart/Index.html
===================================================================
--- src/main/java/org/apache/wicket/quickstart/Index.html (Revision 568574)
+++ src/main/java/org/apache/wicket/quickstart/Index.html (Arbeitskopie)
@@ -5,6 +5,9 @@
<body>
<h1>QuickStart</h1>
<p>This is your first Wicket application.</p>
+ <span background="images/bg.jpg">
+ <p wicket:id="myname">Hello</p>
+ </span>
</body>
</html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-871) Markup hirarchy gets messed up when
value of attribute 'background' is a relative path
Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Funk updated WICKET-871:
-------------------------------
Attachment: RelativePathPrefixHandler.patch
The attached file RelativePathPrefixHandler.patch contains the solution I'd propose.
(plus some minor edditing Eclipse did)
But be warned the solution might not follow the DRY principle close enough, as the introduced
private static class TransparentWebMarkupContainer
already exists like that in:
org.apache.wicket.markup.resolver.MarkupInheritanceResolver.TransparentWebMarkupContainer
> Markup hirarchy gets messed up when value of attribute 'background' is a relative path
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-871
> URL: https://issues.apache.org/jira/browse/WICKET-871
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta2
> Reporter: Martin Funk
> Fix For: 1.3.0-beta4
>
> Attachments: RelativePathPrefixHandler.patch, RelativePathPrefixHandlerTest.patch
>
>
> $ svn diff -r HEAD
> Index: src/main/java/org/apache/wicket/quickstart/Index.java
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.java (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.java (Arbeitskopie)
> @@ -17,6 +17,7 @@
> package org.apache.wicket.quickstart;
>
> import org.apache.wicket.PageParameters;
> +import org.apache.wicket.markup.html.basic.Label;
>
> /**
> * Basic bookmarkable index page.
> @@ -35,5 +36,6 @@
> */
> public Index(final PageParameters parameters)
> {
> + this.add(new Label("myname", "Whishing that this is not a bug."));
> }
> }
> Index: src/main/java/org/apache/wicket/quickstart/Index.html
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.html (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.html (Arbeitskopie)
> @@ -5,6 +5,9 @@
> <body>
> <h1>QuickStart</h1>
> <p>This is your first Wicket application.</p>
> + <span background="images/bg.jpg">
> + <p wicket:id="myname">Hello</p>
> + </span>
> </body>
> </html>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-871) Markup hirarchy gets messed up when
value of attribute 'background' is a relative path
Posted by "Martin Funk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Funk updated WICKET-871:
-------------------------------
Attachment: RelativePathPrefixHandlerTest.patch
The attachment contains a testcase for prooving the bug.
> Markup hirarchy gets messed up when value of attribute 'background' is a relative path
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-871
> URL: https://issues.apache.org/jira/browse/WICKET-871
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta2
> Reporter: Martin Funk
> Fix For: 1.3.0-beta4
>
> Attachments: RelativePathPrefixHandlerTest.patch
>
>
> $ svn diff -r HEAD
> Index: src/main/java/org/apache/wicket/quickstart/Index.java
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.java (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.java (Arbeitskopie)
> @@ -17,6 +17,7 @@
> package org.apache.wicket.quickstart;
>
> import org.apache.wicket.PageParameters;
> +import org.apache.wicket.markup.html.basic.Label;
>
> /**
> * Basic bookmarkable index page.
> @@ -35,5 +36,6 @@
> */
> public Index(final PageParameters parameters)
> {
> + this.add(new Label("myname", "Whishing that this is not a bug."));
> }
> }
> Index: src/main/java/org/apache/wicket/quickstart/Index.html
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.html (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.html (Arbeitskopie)
> @@ -5,6 +5,9 @@
> <body>
> <h1>QuickStart</h1>
> <p>This is your first Wicket application.</p>
> + <span background="images/bg.jpg">
> + <p wicket:id="myname">Hello</p>
> + </span>
> </body>
> </html>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-871) Markup hirarchy gets messed up when
value of attribute 'background' is a relative path
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-871:
--------------------------------
Fix Version/s: 1.3.0-beta4
Affects Version/s: 1.3.0-beta2
> Markup hirarchy gets messed up when value of attribute 'background' is a relative path
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-871
> URL: https://issues.apache.org/jira/browse/WICKET-871
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta2
> Reporter: Martin Funk
> Fix For: 1.3.0-beta4
>
>
> $ svn diff -r HEAD
> Index: src/main/java/org/apache/wicket/quickstart/Index.java
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.java (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.java (Arbeitskopie)
> @@ -17,6 +17,7 @@
> package org.apache.wicket.quickstart;
>
> import org.apache.wicket.PageParameters;
> +import org.apache.wicket.markup.html.basic.Label;
>
> /**
> * Basic bookmarkable index page.
> @@ -35,5 +36,6 @@
> */
> public Index(final PageParameters parameters)
> {
> + this.add(new Label("myname", "Whishing that this is not a bug."));
> }
> }
> Index: src/main/java/org/apache/wicket/quickstart/Index.html
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.html (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.html (Arbeitskopie)
> @@ -5,6 +5,9 @@
> <body>
> <h1>QuickStart</h1>
> <p>This is your first Wicket application.</p>
> + <span background="images/bg.jpg">
> + <p wicket:id="myname">Hello</p>
> + </span>
> </body>
> </html>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-871) Markup hirarchy gets messed up when
value of attribute 'background' is a relative path
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-871.
----------------------------------
Resolution: Fixed
doh, i fixed this earlier today but didnt notice it was already in jira
> Markup hirarchy gets messed up when value of attribute 'background' is a relative path
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-871
> URL: https://issues.apache.org/jira/browse/WICKET-871
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-beta2
> Reporter: Martin Funk
> Fix For: 1.3.0-beta4
>
> Attachments: RelativePathPrefixHandler.patch, RelativePathPrefixHandlerTest.patch
>
>
> $ svn diff -r HEAD
> Index: src/main/java/org/apache/wicket/quickstart/Index.java
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.java (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.java (Arbeitskopie)
> @@ -17,6 +17,7 @@
> package org.apache.wicket.quickstart;
>
> import org.apache.wicket.PageParameters;
> +import org.apache.wicket.markup.html.basic.Label;
>
> /**
> * Basic bookmarkable index page.
> @@ -35,5 +36,6 @@
> */
> public Index(final PageParameters parameters)
> {
> + this.add(new Label("myname", "Whishing that this is not a bug."));
> }
> }
> Index: src/main/java/org/apache/wicket/quickstart/Index.html
> ===================================================================
> --- src/main/java/org/apache/wicket/quickstart/Index.html (Revision 568574)
> +++ src/main/java/org/apache/wicket/quickstart/Index.html (Arbeitskopie)
> @@ -5,6 +5,9 @@
> <body>
> <h1>QuickStart</h1>
> <p>This is your first Wicket application.</p>
> + <span background="images/bg.jpg">
> + <p wicket:id="myname">Hello</p>
> + </span>
> </body>
> </html>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.